Merge lp:~fginther/snappy-proposed-image-tester/rename-queues into lp:snappy-proposed-image-tester

Proposed by Francis Ginther
Status: Merged
Approved by: Francis Ginther
Approved revision: 40
Merged at revision: 39
Proposed branch: lp:~fginther/snappy-proposed-image-tester/rename-queues
Merge into: lp:snappy-proposed-image-tester
Diff against target: 24 lines (+5/-4)
1 file modified
snappy_proposed_image_tester/constants.py (+5/-4)
To merge this branch: bzr merge lp:~fginther/snappy-proposed-image-tester/rename-queues
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Thomi Richards (community) Approve
Paul Larson Approve
Review via email: mp+260392@code.launchpad.net

Commit message

Update queue names to match specification.

Description of the change

Update queue names to match specification.

To post a comment you must log in.
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

lgtm

review: Approve
Revision history for this message
Paul Larson (pwlars) wrote :

looks good

review: Approve
Revision history for this message
Ubuntu CI Bot (uci-bot) wrote :
Download full text (26.7 KiB)

The attempt to merge lp:~fginther/snappy-proposed-image-tester/rename-queues into lp:snappy-proposed-image-tester failed. Below is the output from the failed tests.

Using base prefix '/usr'
New python executable in /tmp/venv-snappy-proposed-image-testerzzws7ou6/bin/python3
Also creating executable in /tmp/venv-snappy-proposed-image-testerzzws7ou6/bin/python
Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/bin/python3
Ignoring indexes: https://pypi.python.org/simple/
Downloading/unpacking kombu==3.0.24 (from -r requirements.txt (line 1))
Downloading/unpacking python-logstash==0.4.2 (from -r requirements.txt (line 2))
  Running setup.py (path:/tmp/venv-snappy-proposed-image-testerzzws7ou6/build/python-logstash/setup.py) egg_info for package python-logstash

Downloading/unpacking python-swiftclient==2.4.0 (from -r requirements.txt (line 3))
Downloading/unpacking python-keystoneclient==1.3.0 (from -r requirements.txt (line 4))
Downloading/unpacking uservice-utils==1.0.2.1 (from -r requirements.txt (line 5))
Downloading/unpacking anyjson>=0.3.3 (from kombu==3.0.24->-r requirements.txt (line 1))
  Running setup.py (path:/tmp/venv-snappy-proposed-image-testerzzws7ou6/build/anyjson/setup.py) egg_info for package anyjson

Downloading/unpacking amqp>=1.4.5,<2.0 (from kombu==3.0.24->-r requirements.txt (line 1))
  Running setup.py (path:/tmp/venv-snappy-proposed-image-testerzzws7ou6/build/amqp/setup.py) egg_info for package amqp

Downloading/unpacking requests>=1.1 (from python-swiftclient==2.4.0->-r requirements.txt (line 3))
Downloading/unpacking futures>=2.1.3 (from python-swiftclient==2.4.0->-r requirements.txt (line 3))
Downloading/unpacking simplejson>=2.0.9 (from python-swiftclient==2.4.0->-r requirements.txt (line 3))
  Running setup.py (path:/tmp/venv-snappy-proposed-image-testerzzws7ou6/build/simplejson/setup.py) egg_info for package simplejson

Downloading/unpacking six>=1.5.2 (from python-swiftclient==2.4.0->-r requirements.txt (line 3))
Downloading/unpacking iso8601>=0.1.9 (from python-keystoneclient==1.3.0->-r requirements.txt (line 4))
Downloading/unpacking Babel>=1.3 (from python-keystoneclient==1.3.0->-r requirements.txt (line 4))
  Running setup.py (path:/tmp/venv-snappy-proposed-image-testerzzws7ou6/build/Babel/setup.py) egg_info for package Babel

    warning: no previously-included files matching '*' found under directory 'docs/_build'
    warning: no previously-included files matching '*.pyc' found under directory 'tests'
    warning: no previously-included files matching '*.pyo' found under directory 'tests'
Downloading/unpacking oslo.config>=1.9.0 (from python-keystoneclient==1.3.0->-r requirements.txt (line 4))
Downloading/unpacking PrettyTable>=0.7,<0.8 (from python-keystoneclient==1.3.0->-r requirements.txt (line 4))
  Running setup.py (path:/tmp/venv-snappy-proposed-image-testerzzws7ou6/build/PrettyTable/setup.py) egg_info for package PrettyTable

Downloading/unpacking argparse (from python-keystoneclient==1.3.0->-r requirements.txt (line 4))
Downloading/unpacking oslo.serialization>=1.2.0 (from python-keystoneclient==1.3.0->-r requirements.txt (line 4))
Downloading/unpackin...

40. By Francis Ginther

Ooops, '=' not '=='!

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) :
review: Approve
Revision history for this message
Celso Providelo (cprov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'snappy_proposed_image_tester/constants.py'
2--- snappy_proposed_image_tester/constants.py 2015-05-27 18:28:14 +0000
3+++ snappy_proposed_image_tester/constants.py 2015-05-28 02:33:07 +0000
4@@ -34,15 +34,16 @@
5 }
6
7 # Queue names are constant, rather than being defined in the config.
8+QUEUE_PREFIX = "snappy-proposed"
9
10 # The queue we listen to for new payloads to check:
11-INPUT_QUEUE = "{}.tests.v1".format(SOLUTION_NAME)
12+INPUT_QUEUE = "{}.tests.v1".format(QUEUE_PREFIX)
13
14 # The queue we put fatally error'd payloads into:
15-DEAD_LETTER_QUEUE = "{}.deadletters.v1".format(SOLUTION_NAME)
16+DEAD_LETTER_QUEUE = "{}.deadletters.v1".format(QUEUE_PREFIX)
17
18 # The queue we put payloads on to re-run the test:
19-TEST_RETRY_QUEUE = "{}.tests.v1".format(SOLUTION_NAME)
20+TEST_RETRY_QUEUE = "{}.tests.v1".format(QUEUE_PREFIX)
21
22 # The queue we put results on:
23-DONE_QUEUE = "{}.result.v1".format(SOLUTION_NAME)
24+DONE_QUEUE = "{}.results.v1".format(QUEUE_PREFIX)

Subscribers

People subscribed via source and target branches