Merge lp:~fginther/phablet-tools/fix-ptr-python3-import-check into lp:phablet-tools
Status: | Merged |
---|---|
Approved by: | Francis Ginther |
Approved revision: | 282 |
Merged at revision: | 289 |
Proposed branch: | lp:~fginther/phablet-tools/fix-ptr-python3-import-check |
Merge into: | lp:phablet-tools |
Diff against target: |
17 lines (+6/-2) 1 file modified
phablet-test-run (+6/-2) |
To merge this branch: | bzr merge lp:~fginther/phablet-tools/fix-ptr-python3-import-check |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Dimitri John Ledkov | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email:
|
Commit message
phablet-test-run: check the return code when attempting to import tests with python3 instead of just looking for text output. Log messages generated on import will cause the import check to fail when it should not.
Description of the change
In phablet-test-run, check the return code when attempting to import tests with python3 instead of just looking for text output. Log messages generated on import will cause the import check to fail when it should not.
This was tested with the following:
- mediaplayer_app (installed from mediaplayer-
This falls back to python 2.
- calendar_app (installed via phablet-
This uses python 3.
- address_book_app (installed from the packages used by https:/
This uses python 3 with this fix (w/o this fix it incorrectly uses python 2)
PASSED: Continuous integration, rev:282 jenkins. qa.ubuntu. com/job/ phablet- tools-ci/ 340/ jenkins. qa.ubuntu. com/job/ phablet- tools-utopic- amd64-ci/ 21 jenkins. qa.ubuntu. com/job/ phablet- tools-utopic- armhf-ci/ 21 jenkins. qa.ubuntu. com/job/ phablet- tools-utopic- i386-ci/ 21
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/phablet- tools-ci/ 340/rebuild
http://