Merge lp:~fginther/livecd-rootfs/xenial-proposed-fix-pollinate-install into lp:~ubuntu-core-dev/livecd-rootfs/xenial-proposed

Proposed by Francis Ginther
Status: Merged
Merged at revision: 1463
Proposed branch: lp:~fginther/livecd-rootfs/xenial-proposed-fix-pollinate-install
Merge into: lp:~ubuntu-core-dev/livecd-rootfs/xenial-proposed
Diff against target: 27 lines (+8/-1)
2 files modified
debian/changelog (+7/-0)
live-build/ubuntu-cpc/hooks/999-cpc-fixes.chroot (+1/-1)
To merge this branch: bzr merge lp:~fginther/livecd-rootfs/xenial-proposed-fix-pollinate-install
Reviewer Review Type Date Requested Status
Philip Roche (community) Approve
Steve Langasek Approve
Review via email: mp+348868@code.launchpad.net

Commit message

Fix install command for pollinate (add '-y') in minimal images

Description of the change

This fixes an image build issue seen when building minimal cloud images. Without the '-y', apt-get will prompt for user input which will break the build.

I've built this change into a package and used it to rebuild the 16.04 set of minimal cloud images:
https://launchpad.net/~cloudware/+livefs/ubuntu/xenial/cpc-development/+build/138244

The portion of the build log related to this code change is here: https://paste.ubuntu.com/p/ZStpHvCB6F/

This regression was a gaff on my part. I did the exact same build on the prior submission, but must have failed to check the correct build results.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) :
review: Approve
Revision history for this message
Philip Roche (philroche) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2018-06-29 22:17:02 +0000
3+++ debian/changelog 2018-07-02 21:24:31 +0000
4@@ -1,3 +1,10 @@
5+livecd-rootfs (2.408.35) xenial; urgency=medium
6+
7+ * Fix the install command for pollinate which is added back to minimal
8+ images (LP: #1779406)
9+
10+ -- Francis Ginther <francis.ginther@canonical.com> Mon, 02 Jul 2018 14:44:34 -0500
11+
12 livecd-rootfs (2.408.34) xenial; urgency=medium
13
14 * Add back pollinate for minimal after it is removed due to a dependency
15
16=== modified file 'live-build/ubuntu-cpc/hooks/999-cpc-fixes.chroot'
17--- live-build/ubuntu-cpc/hooks/999-cpc-fixes.chroot 2018-06-29 19:52:52 +0000
18+++ live-build/ubuntu-cpc/hooks/999-cpc-fixes.chroot 2018-07-02 21:24:31 +0000
19@@ -179,7 +179,7 @@
20 ubuntu-cloudimage-keyring file
21 # Add back pollinate, which gets removed due to a dependency on vim-common
22 _xchroot "${rootd}" env DEBIAN_FRONTEND=noninteractive \
23- apt-get install --no-install-recommends pollinate
24+ apt-get -y install --no-install-recommends pollinate
25
26 _xchroot "${rootd}" apt clean
27 fi

Subscribers

People subscribed via source and target branches