Merge lp:~fginther/helipad/fix_lp1210366 into lp:helipad/ci

Proposed by Francis Ginther
Status: Merged
Approved by: Chris Johnston
Approved revision: 41
Merged at revision: 41
Proposed branch: lp:~fginther/helipad/fix_lp1210366
Merge into: lp:helipad/ci
Diff against target: 17 lines (+6/-1)
1 file modified
util/heuristics.py (+6/-1)
To merge this branch: bzr merge lp:~fginther/helipad/fix_lp1210366
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Chris Johnston Approve
Review via email: mp+180269@code.launchpad.net

Commit message

Default the daily release builds to Published only if the job was SUCCESS.

Description of the change

Default the daily release builds to Published only if the job was SUCCESS.

I was able to verify this on my staging server. W/o this change the bad build showed as 'Published', with this applied, it was 'Failed'. There is no further detail available from these builds.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:41
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~fginther/helipad/fix_lp1210366/+merge/180269/+edit-commit-message

http://s-jenkins:8080/job/helipad-ci-ci/67/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/helipad-ci-ci/67/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'util/heuristics.py'
2--- util/heuristics.py 2013-07-31 22:07:43 +0000
3+++ util/heuristics.py 2013-08-14 23:47:22 +0000
4@@ -20,7 +20,12 @@
5 """Determines the published status given a build instance of an
6 integration job"""
7 build_set = build.downstream_builds.all()
8- status = 'Published'
9+
10+ # Set a sane default status
11+ if build.result.name == 'SUCCESS':
12+ status = 'Published'
13+ else:
14+ status = 'Failed'
15
16 # Set status according to the last failed build in the workflow,
17 # assumes that the builds are organized in the workflow order.

Subscribers

People subscribed via source and target branches

to all changes: