Merge lp:~fginther/fake-juju/fix-makefile-python-path into lp:~landscape/fake-juju/trunk-old

Proposed by Francis Ginther
Status: Merged
Approved by: Francis Ginther
Approved revision: 51
Merged at revision: 56
Proposed branch: lp:~fginther/fake-juju/fix-makefile-python-path
Merge into: lp:~landscape/fake-juju/trunk-old
Diff against target: 38 lines (+8/-4)
2 files modified
Makefile (+6/-2)
python/setup.py (+2/-2)
To merge this branch: bzr merge lp:~fginther/fake-juju/fix-makefile-python-path
Reviewer Review Type Date Requested Status
Eric Snow (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+311303@code.launchpad.net

Commit message

Update Makefile and setup.py to install 'PyYAML' and with with yakkety python-setuptools.

Description of the change

Update Makefile and setup.py to install 'PyYAML' and with with yakkety python-setuptools.

Testing instructions:
1) Make yakkety, xenial, trusty and precise packages with sbuild

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 51
Branch: lp:~fginther/fake-juju/fix-makefile-python-path
Jenkins: https://ci.lscape.net/job/latch-test-xenial/974/

review: Approve (test results)
Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2016-11-18 12:49:28 +0000
3+++ Makefile 2016-11-18 19:38:36 +0000
4@@ -129,7 +129,11 @@
5 ifndef PYTHON_INSTALLDIR
6 PYTHON_INSTALLDIR = $(DESTDIR)/usr/lib/python2.7/dist-packages
7 endif
8-PYTHON_INSTALL_OPTION = --install-lib $(PYTHON_INSTALLDIR)
9+ifndef PYTHON_SCRIPTDIR
10+PYTHON_SCRIPTDIR = $(DESTDIR)/usr/local/bin
11+endif
12+MODULEDIR = $(DESTDIR)/usr/local/bin
13+PYTHON_INSTALL_OPTION = --install-lib $(PYTHON_INSTALLDIR) --install-scripts $(PYTHON_SCRIPTDIR)
14
15 PYTHON_LIB_ROOT = $(shell pwd)/python
16 # TODO: read from python/fakejuju/__init__.py
17@@ -149,7 +153,7 @@
18 if [ ! "$(SKIP_PYTHON_LIB)" ]; then \
19 mkdir -p $(PYTHON_INSTALLDIR); \
20 cd python; \
21- $(PYTHON) setup.py install $(PYTHON_INSTALL_OPTION); \
22+ PYTHONPATH=$(PYTHON_INSTALLDIR):$$PYTHONPATH $(PYTHON) setup.py install $(PYTHON_INSTALL_OPTION); \
23 fi
24
25 .PHONY: py-install-dev
26
27=== modified file 'python/setup.py'
28--- python/setup.py 2016-10-24 20:21:11 +0000
29+++ python/setup.py 2016-11-18 19:38:36 +0000
30@@ -45,8 +45,8 @@
31 DEPS = ['fixtures',
32 'testtools',
33 'txjuju',
34- 'twisted',
35- 'yaml',
36+ 'Twisted',
37+ 'PyYAML',
38 ]
39
40

Subscribers

People subscribed via source and target branches