Merge lp:~fginther/core-image-tester/edge-support into lp:core-image-tester

Proposed by Francis Ginther
Status: Rejected
Rejected by: Francis Ginther
Proposed branch: lp:~fginther/core-image-tester/edge-support
Merge into: lp:core-image-tester
Diff against target: 29 lines (+4/-1)
1 file modified
core_image_tester/worker.py (+4/-1)
To merge this branch: bzr merge lp:~fginther/core-image-tester/edge-support
Reviewer Review Type Date Requested Status
Celso Providelo (community) Needs Information
Review via email: mp+257166@code.launchpad.net

Commit message

Add support for 'release'.

Description of the change

Add support for 'release'.

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) wrote :

Francis,

As discussed on IRC, if we hardcode configuration channel as "ubuntu-core/rolling/edge" in the deployer, this change wouldn't be necessary.

review: Needs Information
Revision history for this message
Francis Ginther (fginther) wrote :

Rejecting as a different solution was implemented that only required modifications to the publisher.

Unmerged revisions

32. By Francis Ginther

Add support for 'release'.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'core_image_tester/worker.py'
2--- core_image_tester/worker.py 2015-04-17 16:02:30 +0000
3+++ core_image_tester/worker.py 2015-04-22 19:42:01 +0000
4@@ -56,6 +56,7 @@
5 nova_image_id = body['nova_image_id']
6 image_name = body['image_name']
7 device = body['device']
8+ release = body['release']
9 channel = body['channel']
10 except KeyError as e:
11 logger.error("Message does not contain required ", extra=extra)
12@@ -97,7 +98,8 @@
13 extra=extra
14 )
15
16- container_name = "core-{}-{}-{}".format(
17+ container_name = "core-{}-{}-{}-{}".format(
18+ release,
19 channel,
20 device,
21 image_name,
22@@ -146,6 +148,7 @@
23
24 """
25 key_whitelist = [
26+ 'release',
27 'channel',
28 'device',
29 'test_branch',

Subscribers

People subscribed via source and target branches