Merge lp:~fginther/core-image-publisher/hardcoded-edge-rolling into lp:core-image-publisher

Proposed by Francis Ginther
Status: Merged
Approved by: Celso Providelo
Approved revision: 29
Merged at revision: 28
Proposed branch: lp:~fginther/core-image-publisher/hardcoded-edge-rolling
Merge into: lp:core-image-publisher
Diff against target: 29 lines (+10/-2)
1 file modified
core_image_publisher/worker.py (+10/-2)
To merge this branch: bzr merge lp:~fginther/core-image-publisher/hardcoded-edge-rolling
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Thomi Richards (community) Approve
Review via email: mp+257175@code.launchpad.net

Commit message

Hardcode core image download to edge and rolling, ignoring the passed in channel.

This also uses a different approach for getting rid of the .gnupg dir owned by root as suggested here:
https://code.launchpad.net/~fginther/core-image-publisher/edge-support/+merge/257165

Description of the change

Hardcode core image download to edge and rolling, ignoring the passed in channel.

To post a comment you must log in.
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

LGTM

review: Approve
Revision history for this message
Celso Providelo (cprov) :
review: Approve
29. By Francis Ginther

Remove import getpass as it's not needed anymore.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'core_image_publisher/worker.py'
2--- core_image_publisher/worker.py 2015-04-08 20:14:12 +0000
3+++ core_image_publisher/worker.py 2015-04-23 01:33:19 +0000
4@@ -115,16 +115,24 @@
5 # worker and perform testing retries.
6 'HOME': tmpdir,
7 }
8+ # The folling uses hardcoded parameters for '--channel' and 'release'.
9+ # It is ignoring the channel value passed in.
10 cmd = ['sudo',
11 'ubuntu-device-flash',
12 '--revision', name,
13 'core',
14 '--device', device,
15- '--channel', channel,
16+ '--channel', 'edge',
17 '--size', '3',
18 '-o', image_path,
19 '--developer-mode',
20- '--cloud']
21+ '--cloud',
22+ 'rolling']
23+ check_call(cmd, env=udf_env)
24+ cmd = ['sudo',
25+ 'rm',
26+ '-rf',
27+ os.path.join(tmpdir, '.gnupg')]
28 check_call(cmd, env=udf_env)
29 return image_path
30

Subscribers

People subscribed via source and target branches