Merge lp:~fginther/charms/trusty/snappy-proposed-image-tester/renames into lp:~canonical-ci-engineering/charms/trusty/snappy-proposed-image-tester/trunk

Proposed by Francis Ginther
Status: Merged
Approved by: Francis Ginther
Approved revision: 9
Merged at revision: 7
Proposed branch: lp:~fginther/charms/trusty/snappy-proposed-image-tester/renames
Merge into: lp:~canonical-ci-engineering/charms/trusty/snappy-proposed-image-tester/trunk
Diff against target: 116 lines (+17/-15)
6 files modified
README (+5/-4)
config.yaml (+2/-1)
hooks/actions.py (+2/-2)
hooks/services.py (+2/-2)
metadata.yaml (+3/-3)
templates/upstart.conf (+3/-3)
To merge this branch: bzr merge lp:~fginther/charms/trusty/snappy-proposed-image-tester/renames
Reviewer Review Type Date Requested Status
Joe Talbott (community) Approve
Paul Larson Approve
Review via email: mp+260324@code.launchpad.net

Commit message

Renames for core-image-tester to snappy-proposed-image-tester.

Description of the change

Renames for core-image-tester to snappy-proposed-image-tester.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

Looks good

review: Approve
Revision history for this message
Joe Talbott (joetalbott) wrote :

One inline comment.

review: Approve
8. By Francis Ginther

Fix README grammar.

Revision history for this message
Joe Talbott (joetalbott) :
review: Approve
9. By Francis Ginther

Also rename core-service.conf -> snappy-proposed-service.conf.

Revision history for this message
Joe Talbott (joetalbott) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README'
2--- README 2015-03-25 04:36:21 +0000
3+++ README 2015-05-27 15:48:39 +0000
4@@ -1,7 +1,7 @@
5 Overview
6 --------
7
8-This charm install core-image-tester service.
9+This charm installs the snappy-proposed-image-tester service.
10
11 Configuration
12 -------------
13@@ -9,8 +9,9 @@
14 There is only one config option for this charm:
15
16 * config-file: A base64 encoded string with the config file to use for
17- core-image-tester.
18+ snappy-proposed-image-tester.
19
20 The charm expects the payload code to be provided as
21-files/core-image-tester.tgz (a snapshot of lp:core-image-tester) along
22-with its corresponding files/pip-cache directory (python dependencies).
23+files/snappy-proposed-image-tester.tgz (a snapshot of
24+lp:snappy-proposed-image-tester) along with its corresponding files/pip-cache
25+directory (python dependencies).
26
27=== modified file 'config.yaml'
28--- config.yaml 2015-03-25 04:36:21 +0000
29+++ config.yaml 2015-05-27 15:48:39 +0000
30@@ -7,5 +7,6 @@
31 config-file:
32 type: string
33 description: |
34- base64 encoded string with the config file for core-image-tester
35+ base64 encoded string with the config file for
36+ snappy-proposed-image-tester
37
38
39=== modified file 'hooks/actions.py'
40--- hooks/actions.py 2015-04-28 02:09:37 +0000
41+++ hooks/actions.py 2015-05-27 15:48:39 +0000
42@@ -8,8 +8,8 @@
43 from charmhelpers.core.host import adduser
44 from charmhelpers.payload import (archive, execd)
45
46-SERVICE_NAME = 'core-image-tester'
47-SERVICE_CONFIGNAME = 'core-service.conf'
48+SERVICE_NAME = 'snappy-proposed-image-tester'
49+SERVICE_CONFIGNAME = 'snappy-proposed-service.conf'
50 REQUIRED_PACKAGES = [
51 'autopkgtest', 'bzr', 'python-novaclient', 'python-virtualenv',
52 'python3-dev', 'gcc',
53
54=== modified file 'hooks/services.py'
55--- hooks/services.py 2015-04-28 02:09:37 +0000
56+++ hooks/services.py 2015-05-27 15:48:39 +0000
57@@ -11,7 +11,7 @@
58 config = hookenv.config()
59 manager = ServiceManager([
60 {
61- 'service': 'core-image-tester',
62+ 'service': 'snappy-proposed-image-tester',
63 'required_data': [config],
64 'data_ready': [
65 actions.basenode,
66@@ -22,7 +22,7 @@
67 actions.create_user,
68 helpers.render_template(
69 source='upstart.conf',
70- target='/etc/init/core-image-tester.conf'),
71+ target='/etc/init/snappy-proposed-image-tester.conf'),
72 actions.log_start,
73 ],
74 },
75
76=== modified file 'metadata.yaml'
77--- metadata.yaml 2015-03-25 04:36:21 +0000
78+++ metadata.yaml 2015-05-27 15:48:39 +0000
79@@ -1,8 +1,8 @@
80-name: core-image-tester
81+name: snappy-proposed-image-tester
82 summary: |
83 Deploy a service to test new ubuntucore images receiving requests via
84 rabbit queues.
85 maintainer: Canonical CI Engineering <canonical-ci-engineering@lists.launchpad.net>
86 description: |
87- Runs core-image-tester service from a given service tarball (provided as
88- files/core-image-tester.tgz).
89+ Runs snappy-proposed-image-tester service from a given service tarball
90+ (provided as files/snappy-proposed-image-tester.tgz).
91
92=== modified file 'templates/upstart.conf'
93--- templates/upstart.conf 2015-03-25 04:36:21 +0000
94+++ templates/upstart.conf 2015-05-27 15:48:39 +0000
95@@ -1,4 +1,4 @@
96-description "Starts a core-image-tester process"
97+description "Starts a snappy-proposed-image-tester process"
98
99 start on (local-filesystems and net-device-up IFACE=eth0)
100 stop on runlevel [!12345]
101@@ -11,13 +11,13 @@
102 # unless it fails 15 times within 5 seconds
103 respawn limit 15 5
104
105-env SERVICE_DIR=/srv/{{ environment }}/core-image-tester
106+env SERVICE_DIR=/srv/{{ environment }}/snappy-proposed-image-tester
107 env SERVICE_USER=core-worker
108
109 script
110
111 install -d -o ${SERVICE_USER} ${SERVICE_DIR}/logs
112 chdir ${SERVICE_DIR}
113- exec sudo -u ${SERVICE_USER} sh -c "./ve/bin/python3 core-image-tester.py -c ${SERVICE_DIR}/core-service.conf >> logs/core-image-tester.log 2>&1"
114+ exec sudo -u ${SERVICE_USER} sh -c "./ve/bin/python3 snappy-proposed-image-tester.py -c ${SERVICE_DIR}/snappy-proposed-service.conf >> logs/snappy-proposed-image-tester.log 2>&1"
115
116 end script

Subscribers

People subscribed via source and target branches