Code review comment for lp:~fginther/charms/trusty/jenkins-remote-slave/cloud-worker-swap-fix

Revision history for this message
Para Siva (psivaa) wrote :

Thanks a lot Francis for working on this.

I'm not sure if a charm upgrade with this change will fix currently deployed slaves. This is because the code execution would not reach the code where you edit /etc/fstab. Since there is already a swapfile at /.

New charm deployments will be certainly free of this bug.

I'm marking this as 'Needs fixing' but feel free to ignore, since this fix may not be intended to be applied to all the slaves deployed everywhere.

review: Needs Fixing

« Back to merge proposal