Code review comment for lp:~fginther/adt-continuous-deployer/beefier-testbeds

Revision history for this message
Celso Providelo (cprov) wrote :

Francis,

Looks good, but configuration flavor only affects core-image-testing solution, adt-cloud-worker uses a dedicated method to calculate suitable flavors using nova API (_cloud_support/get_default_testbed_flavor) with 'cpu2-ram2-disk10' hardcoded as fallback.

The simplest way a see to get this solved is to submit another MP for adt-cloud-worker to replace the hardcoded value with the configuration one. Although, the whole flavor-logic is unnecessary IMO and we should simply use whatever is defined in the configuration.

Anyway, this fix is perfectly fine and effective for core-image-testing, so I am approving it.

review: Approve

« Back to merge proposal