Merge ~fginther/+git/raspi-rt:fginther/bionic-install-deps into ~juergh/+git/raspi-rt-tests:main

Proposed by Francis Ginther
Status: Needs review
Proposed branch: ~fginther/+git/raspi-rt:fginther/bionic-install-deps
Merge into: ~juergh/+git/raspi-rt-tests:main
Diff against target: 12 lines (+0/-1)
1 file modified
lib/run-test (+0/-1)
Reviewer Review Type Date Requested Status
Juerg Haefliger Pending
Review via email: mp+412643@code.launchpad.net

Commit message

install-deps: Don't capitalize RT_OS_CODENAME

Doing so will result in any codename checks failing if they also don't
use a capitalized string.

Signed-off-by: Francis Ginther <email address hidden>

Description of the change

The following will fail to skip bionic due to the capitalization:

    # Add dependencies required by this script
    if [ "${RT_OS_CODENAME}" != "bionic" ] ; then
        deps+=(libraspberrypi-bin)
    fi

I fine it easier to keep these string as returned to avoid having issues the next time a codename specific condition is needed.

To post a comment you must log in.

Unmerged commits

4af6839... by Francis Ginther

install-deps: Don't capitalize RT_OS_CODENAME

Doing so will result in any codename checks failing if they also don't
use a capitalized string.

Signed-off-by: Francis Ginther <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/run-test b/lib/run-test
2index fb50297..dd903ed 100755
3--- a/lib/run-test
4+++ b/lib/run-test
5@@ -104,7 +104,6 @@ function _set_globals()
6 # OS Codename
7 RT_OS_CODENAME=$(lsb_release -s -c)
8 RT_OS_CODENAME=${RT_OS_CODENAME,,}
9- RT_OS_CODENAME=${RT_OS_CODENAME^}
10
11 # System information
12 RT_UNAME=$(uname -a)

Subscribers

People subscribed via source and target branches