Merge lp:~fgimenez/snappy/fix-activate-test into lp:~snappy-dev/snappy/snappy-moved-to-github

Proposed by Federico Gimenez
Status: Merged
Approved by: Leo Arias
Approved revision: 766
Merged at revision: 768
Proposed branch: lp:~fgimenez/snappy/fix-activate-test
Merge into: lp:~snappy-dev/snappy/snappy-moved-to-github
Diff against target: 28 lines (+7/-3)
1 file modified
_integration-tests/tests/activate_test.go (+7/-3)
To merge this branch: bzr merge lp:~fgimenez/snappy/fix-activate-test
Reviewer Review Type Date Requested Status
Leo Arias (community) Approve
Review via email: mp+274268@code.launchpad.net

Commit message

activate test skipped on 15.04 and moved Suite related fixtures to Test fixtures

Description of the change

activate test skipped on 15.04 and moved Suite related fixtures to Test fixtures

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

lgtm.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '_integration-tests/tests/activate_test.go'
2--- _integration-tests/tests/activate_test.go 2015-10-09 07:49:19 +0000
3+++ _integration-tests/tests/activate_test.go 2015-10-13 14:52:44 +0000
4@@ -45,17 +45,21 @@
5 snapPath string
6 }
7
8-func (s *activateSuite) SetUpSuite(c *check.C) {
9- s.SnappySuite.SetUpSuite(c)
10+func (s *activateSuite) SetUpTest(c *check.C) {
11+ s.SnappySuite.SetUpTest(c)
12+ if common.Release(c) == "15.04" {
13+ c.Skip("activate CLI command not available on 15.04, reenable the test when present")
14+ }
15 var err error
16 s.snapPath, err = build.LocalSnap(c, activateSnapName)
17 c.Assert(err, check.IsNil)
18 common.InstallSnap(c, s.snapPath)
19 }
20
21-func (s *activateSuite) TearDownSuite(c *check.C) {
22+func (s *activateSuite) TearDownTest(c *check.C) {
23 os.Remove(s.snapPath)
24 common.RemoveSnap(c, activateSnapName)
25+ s.SnappySuite.TearDownTest(c)
26 }
27
28 func (s *activateSuite) TestDeactivateRemovesBinary(c *check.C) {

Subscribers

People subscribed via source and target branches