Merge lp:~fgimenez/snappy/extended-ssh-timeout into lp:~snappy-dev/snappy/snappy-moved-to-github

Proposed by Federico Gimenez on 2015-08-31
Status: Merged
Approved by: Leo Arias on 2015-09-17
Approved revision: 642
Merged at revision: 708
Proposed branch: lp:~fgimenez/snappy/extended-ssh-timeout
Merge into: lp:~snappy-dev/snappy/snappy-moved-to-github
Diff against target: 37 lines (+8/-3)
2 files modified
_integration-tests/testutils/autopkgtest/autopkgtest_test.go (+2/-1)
_integration-tests/testutils/autopkgtest/ssh.go (+6/-2)
To merge this branch: bzr merge lp:~fgimenez/snappy/extended-ssh-timeout
Reviewer Review Type Date Requested Status
Leo Arias 2015-08-31 Approve on 2015-08-31
Review via email: mp+269631@code.launchpad.net

Commit Message

Extended ssh timeout

Description of the Change

Extended ssh timeout

To post a comment you must log in.
Leo Arias (elopio) wrote :

Great. +1, waiting for the new adt-run release.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '_integration-tests/testutils/autopkgtest/autopkgtest_test.go'
2--- _integration-tests/testutils/autopkgtest/autopkgtest_test.go 2015-08-25 16:59:19 +0000
3+++ _integration-tests/testutils/autopkgtest/autopkgtest_test.go 2015-08-31 11:22:22 +0000
4@@ -199,7 +199,8 @@
5 func adtrunRemoteCmd(controlFile, sourceCodePath, outputDir, testbedIP string, testbedPort int) string {
6 port := strconv.Itoa(testbedPort)
7 idFile := filepath.Join(os.Getenv("HOME"), ".ssh", "id_rsa")
8- options := fmt.Sprintf("--- ssh -H %s -p %s -l ubuntu -i %s --reboot", testbedIP, port, idFile)
9+ options := fmt.Sprintf("--- ssh -H %s -p %s -l ubuntu -i %s --reboot --timeout-ssh %d",
10+ testbedIP, port, idFile, sshTimeout)
11
12 return adtrunCommonCmd(controlFile, sourceCodePath, outputDir, options)
13 }
14
15=== modified file '_integration-tests/testutils/autopkgtest/ssh.go'
16--- _integration-tests/testutils/autopkgtest/ssh.go 2015-08-07 15:58:38 +0000
17+++ _integration-tests/testutils/autopkgtest/ssh.go 2015-08-31 11:22:22 +0000
18@@ -26,7 +26,10 @@
19 "strconv"
20 )
21
22-const commonSSHOptions = "--- ssh "
23+const (
24+ commonSSHOptions = "--- ssh "
25+ sshTimeout = 600
26+)
27
28 func kvmSSHOptions(imagePath string) string {
29 return fmt.Sprint(commonSSHOptions,
30@@ -39,5 +42,6 @@
31 " -p ", strconv.Itoa(testbedPort),
32 " -l ubuntu",
33 " -i ", filepath.Join(os.Getenv("HOME"), ".ssh", "id_rsa"),
34- " --reboot")
35+ " --reboot",
36+ " --timeout-ssh ", strconv.Itoa(sshTimeout))
37 }

Subscribers

People subscribed via source and target branches