Merge lp:~fgimenez/goget-ubuntu-touch/autopkgtest into lp:goget-ubuntu-touch

Proposed by Federico Gimenez
Status: Needs review
Proposed branch: lp:~fgimenez/goget-ubuntu-touch/autopkgtest
Merge into: lp:goget-ubuntu-touch
Prerequisite: lp:~sergiusens/goget-ubuntu-touch/snappy-catchup
Diff against target: 14 lines (+4/-0)
2 files modified
debian/tests/cli (+2/-0)
debian/tests/control (+2/-0)
To merge this branch: bzr merge lp:~fgimenez/goget-ubuntu-touch/autopkgtest
Reviewer Review Type Date Requested Status
Leo Arias (community) Needs Information
Sergio Schvezov Approve
Review via email: mp+277031@code.launchpad.net

Commit message

Simple test, requires build and tries the executable. It can be executed from the branch with:

$ adt-run --unbuilt-tree=$PWD --- qemu ~/adt-wily-amd64-cloud.img

Description of the change

Simple test, requires build and tries the executable

To post a comment you must log in.
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

lgtm and sufficient to see if any go api breaks us in order to always be in sync

review: Approve
Revision history for this message
Leo Arias (elopio) wrote :

looks good but when I run it here it fails: http://pastebin.ubuntu.com/13210569/

am I doing something wrong?

review: Needs Information
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

On Mon, Nov 9, 2015 at 4:31 PM, Leo Arias <email address hidden> wrote:

> Review: Needs Information
>
> looks good but when I run it here it fails:
> http://pastebin.ubuntu.com/13210569/
>
> am I doing something wrong?
>

The snappy package golang-snappy-dev to make this work is only on xenial.

Revision history for this message
Leo Arias (elopio) wrote :

my xenial machine built with adt-buildvm-ubuntu-cloud does not boot. I'll try to check what's wrong with that, but if you have already tested this, go ahead and merge it.

Revision history for this message
Federico Gimenez (fgimenez) wrote :

I'm having the same problem with adt-buildvm-ubuntu-cloud and xenial, I'll try to create a wily one, upgrade to xenial and run the test

Revision history for this message
Federico Gimenez (fgimenez) wrote :

These are the results [1], seems to build fine but in the test itself there's a problem after installing, don't know if it's related to the custom image used.

[1] http://paste.ubuntu.com/13237086/

Unmerged revisions

223. By Federico Gimenez

added new lines..

222. By Federico Gimenez

cli executable

221. By Federico Gimenez

added missing file

220. By Federico Gimenez

renamed test to cli

219. By Federico Gimenez

basic autopkgtest

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'debian/tests'
2=== added file 'debian/tests/cli'
3--- debian/tests/cli 1970-01-01 00:00:00 +0000
4+++ debian/tests/cli 2015-11-09 17:06:31 +0000
5@@ -0,0 +1,2 @@
6+#!/bin/sh
7+ubuntu-device-flash --help
8
9=== added file 'debian/tests/control'
10--- debian/tests/control 1970-01-01 00:00:00 +0000
11+++ debian/tests/control 2015-11-09 17:06:31 +0000
12@@ -0,0 +1,2 @@
13+Tests: cli
14+Restrictions: build-needed

Subscribers

People subscribed via source and target branches