Merge lp:~fgimenez/autopilot/dev-dependencies into lp:autopilot

Proposed by Federico Gimenez
Status: Needs review
Proposed branch: lp:~fgimenez/autopilot/dev-dependencies
Merge into: lp:autopilot
Diff against target: 11 lines (+1/-0)
1 file modified
docs/faq/contribute.rst (+1/-0)
To merge this branch: bzr merge lp:~fgimenez/autopilot/dev-dependencies
Reviewer Review Type Date Requested Status
Thomi Richards (community) Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+245955@code.launchpad.net

Description of the change

Added development dependencies and updated doc.

After branching the project it is not possible to run the test suite as described in the contribute doc, there are a few missing modules in a clean box. I've added these dependencies in a separate requirements/development.txt file, don't know if this place is fine, and updated the contribute doc, it includes also the installation of the python3-dev package required by the psutil module.

Thx!

To post a comment you must log in.
522. By Federico Gimenez

Added python-autopilot install command

Revision history for this message
Federico Gimenez (fgimenez) wrote :

For completeness I've added explicitly the installation of the python-autopilot package, perhaps there is a less generic package that pulls all the required dependencies.

523. By Federico Gimenez

All the dependencies pulled by packages

Revision history for this message
Federico Gimenez (fgimenez) wrote :

In fact with the python3-autopilot package the only missing dependency is the dateutil module

524. By Federico Gimenez

python3-dateutil is already a python3-autopilot dependency

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:524
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~fgimenez/autopilot/dev-dependencies/+merge/245955/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/autopilot-ci/1015/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-amd64-ci/78
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-amd64-ci/78/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-armhf-ci/78
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-armhf-ci/78/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-i386-ci/78
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-i386-ci/78/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1446
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid-autopilot/111
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1280
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1444
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1444/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18203
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid-autopilot/107
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/747
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/747/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/1015/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Hi,

A better way to do this is to install the debian build deps for the package. The difference is subtle - your approach will install the runtime dependencies, which is (probably) a subset of the build-time dependencies. For example, we may have modules that we use to run our tests that aren't needed at runtime.

I think this command should be:

sudo mk-build-deps -i

note that in order to run that, you need 'devscripts' and 'equivs' packages installed first.

Also - if python3-autopilot does not install the dateutil module, _and_ it's needed at runtime, then that's another bug that needs to be fixed :D

Cheers,

review: Needs Fixing
Revision history for this message
Federico Gimenez (fgimenez) wrote :

Ok, what about the ugly:

grep-dctrl Build-Depends -s Build-Depends -n ./debian/control | sed ':a;N;$!ba;s/\n/ /g' | sed 's/,\s*/ /g' | sed -r 's/ \(>=\s([0-9]\.?)*\) / /g' | sed -r 's/ \| ([a-z0-9\.\-])* / /' | xargs sudo apt-get install -y

This would install only the required packages, but would scare anyone that happens to read it :D

As you propose it, it would be:

sudo apt-get install devscripts equivs && sudo mk-build-deps -i

isn't it?

Unmerged revisions

524. By Federico Gimenez

python3-dateutil is already a python3-autopilot dependency

523. By Federico Gimenez

All the dependencies pulled by packages

522. By Federico Gimenez

Added python-autopilot install command

521. By Federico Gimenez

Added development dependencies and updated doc

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'docs/faq/contribute.rst'
2--- docs/faq/contribute.rst 2014-05-21 14:16:15 +0000
3+++ docs/faq/contribute.rst 2015-01-11 12:45:15 +0000
4@@ -63,6 +63,7 @@
5
6 $ bzr branch lp:autopilot ~/src/autopilot/trunk
7 $ cd ~/src/autopilot/trunk
8+ $ sudo apt-get install python3-autopilot
9 $ python3 -m autopilot.run list autopilot.tests
10
11 Loading tests from: /home/example/src/autopilot/trunk

Subscribers

People subscribed via source and target branches