Code review comment for lp:~fgiff/linaro-android-build-tools/884931

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Well, my concern about such things is that in some time we'll have couple of dozen artifact files, some of them with not very clear names, so people will start to ask "what are all these files?!!1". ".config" is of course obvious for anyone who did kernel hacking, but for those who didn't? (It seems such people exist in the world and nonetheless may be interested in Linaro builds). Oh, and how's busybox' config is called?

So, I strongly suggest having it as kernel_defconfig or maybe even android_kernel_defconfig . That naming is also compatible with actual kernel defconfigs, so it can be used as such.

review: Needs Fixing

« Back to merge proposal