Merge lp:~fgiff/linaro-android-build-tools/884931 into lp:linaro-android-build-tools

Proposed by Frans Gifford
Status: Merged
Approved by: Paul Sokolovsky
Approved revision: 360
Merged at revision: 362
Proposed branch: lp:~fgiff/linaro-android-build-tools/884931
Merge into: lp:linaro-android-build-tools
Diff against target: 11 lines (+2/-0)
1 file modified
build-scripts/build-android (+2/-0)
To merge this branch: bzr merge lp:~fgiff/linaro-android-build-tools/884931
Reviewer Review Type Date Requested Status
Paul Sokolovsky Needs Fixing
Review via email:
To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Well, my concern about such things is that in some time we'll have couple of dozen artifact files, some of them with not very clear names, so people will start to ask "what are all these files?!!1". ".config" is of course obvious for anyone who did kernel hacking, but for those who didn't? (It seems such people exist in the world and nonetheless may be interested in Linaro builds). Oh, and how's busybox' config is called?

So, I strongly suggest having it as kernel_defconfig or maybe even android_kernel_defconfig . That naming is also compatible with actual kernel defconfigs, so it can be used as such.

review: Needs Fixing
Revision history for this message
Frans Gifford (fgiff) wrote :

Fair point, .config is ambiguous, but defconfig is potentially misleading too: I want to be clear that this is the kernel config we really used, so if a build makes defconfig and then uses scripts/config to change some options, this artifact is the .config we built and not necessarily the same as the defconfig.

I'll fix this to call it kernel_config unless there are better suggestions.

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

> not necessarily the same as the defconfig.

Yes, that would be the "new" "defconfig" from user's point of view - one can drop it to kernel's tree at arch/arm/configs/ , type "make kernel_defconfig" (that would do "make oldconfig" underneath too) and get exact kernel configuration as was used for the build. But kernel_config sounds fine too (user would need to manually rename to .config and run make oldconfig then).

360. By Frans Gifford

Rename .config build artifact to kernel_config so it's clear whose config it is.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build-scripts/build-android'
2--- build-scripts/build-android 2011-10-10 14:25:44 +0000
3+++ build-scripts/build-android 2011-11-07 09:57:23 +0000
4@@ -73,6 +73,8 @@
5 tar -cj -C /tmp/sysroot -f out/sysroot.tar.bz2 .
6 fi
8+# Store kernel .config as a build artifact
9+(cp kernel/.config out/kernel_config) || true
10 # Create md5sums file for platform artifacts
11 (cd out/target/product/*/; md5sum *.tar.bz2 >MD5SUMS) || true


People subscribed via source and target branches