Merge lp:~fgallina/rnr-server/no-deb-review-edit-limit into lp:rnr-server

[Fabián Ezequiel Gallina]

Do not limit deb review edit time

Fixes #1540635

[Matias Bordese (matiasb)]

review: Approve

=== modified file 'django_project/settings_base.py'
--- django_project/settings_base.py	2015-12-14 07:30:12 +0000
+++ django_project/settings_base.py	2016-02-19 17:13:55 +0000
@@ -298,7 +298,6 @@
     'reviewsapp.middleware.stats.GraphiteMiddleware',
 ]
 MODERATORS_GROUP = 'rnr-moderators'
-MODIFY_WINDOW_MINUTES = 120
 MONTH_DAY_FORMAT = 'F j'
 NON_PPA_ARCHIVE_ROOTS = {
     'http://extras.ubuntu.com/': 'lp-ppa-app-review-board',

=== modified file 'src/reviewsapp/api/handlers.py'
--- src/reviewsapp/api/handlers.py	2014-10-09 19:32:45 +0000
+++ src/reviewsapp/api/handlers.py	2016-02-19 17:13:55 +0000
@@ -361,13 +361,7 @@
         """Uses PUT verb to modify an existing review"""
         review = get_object_or_404(Review, id=review_id, reviewer=request.user)
 
-        # check review modify window has not closed before allowing update
-        time_diff = datetime.now(pytz.utc) - review.date_created
-        time_limit = timedelta(minutes=settings.MODIFY_WINDOW_MINUTES)
-        if time_diff > time_limit:
-            return HttpResponseForbidden(
-                "This review cannot be edited (edit window expired).")
-        elif review.is_awaiting_moderation():
+        if review.is_awaiting_moderation():
             return HttpResponseForbidden(
                 "This review cannot be edited (pending moderation).")
         else:

=== modified file 'src/reviewsapp/tests/test_handlers.py'
--- src/reviewsapp/tests/test_handlers.py	2014-10-09 19:32:45 +0000
+++ src/reviewsapp/tests/test_handlers.py	2016-02-19 17:13:55 +0000
@@ -1236,14 +1236,6 @@
                                           review.reviewer)
         self.assertEqual(httplib.FORBIDDEN, response.status_code)
 
-    def test_modify_time_limits(self):
-        old_time = (datetime.now(pytz.utc) -
-                    timedelta(settings.MODIFY_WINDOW_MINUTES + 60))
-        review = self.factory.makeReview(date_created=old_time)
-        response = self._modify_review_id(
-            review.id, self.post_data, review.reviewer)
-        self.assertEqual(httplib.FORBIDDEN, response.status_code)
-
     def test_stats_update_on_modify(self):
         software_item = self.factory.makeSoftwareItem(
             package_name='compiz-core',