Code review comment for lp:~fgallina/rnr-server/click-reviews-return-useroid-as-username

The attempt to merge lp:~fgallina/rnr-server/click-reviews-return-useroid-as-username into lp:rnr-server failed. Below is the output from the failed tests.

rm -rf ./virtualenv
sed -e '1,/# Dependencies/d;s/^rnr-server/./g;s/bazaar.isd/bazaar.launchpad.net/g' config-manager.txt > config-manager.txt.tmp
/usr/lib/config-manager/cm.py update config-manager.txt.tmp
Not deleting ./virtualenv/bin
New python executable in ./virtualenv/bin/python
Installing distribute.............................................................................................................................................................................................done.
Installing pip...............done.
./virtualenv/bin/pip install -r requirements.txt
Requirement already satisfied (use --upgrade to upgrade): coverage in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 4))
Downloading/unpacking django-factory==0.11 (from -r requirements.txt (line 5))
  Downloading django_factory-0.11.tar.gz
  Running setup.py egg_info for package django-factory

    warning: no previously-included files matching '*.pyc' found anywhere in distribution
Requirement already satisfied (use --upgrade to upgrade): mechanize in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 6))
Requirement already satisfied (use --upgrade to upgrade): mock in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 7))
Requirement already satisfied (use --upgrade to upgrade): paste==1.7.5.1 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 8))
Requirement already satisfied (use --upgrade to upgrade): pep8 in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 9))
Requirement already satisfied (use --upgrade to upgrade): piston-mini-client in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 10))
Requirement already satisfied (use --upgrade to upgrade): testtools in /usr/lib/python2.7/dist-packages (from -r requirements.txt (line 11))
Downloading/unpacking wsgi-intercept==0.5.1 (from -r requirements.txt (line 12))
  Running setup.py egg_info for package wsgi-intercept

Requirement already satisfied (use --upgrade to upgrade): django>=1.1 in /usr/lib/python2.7/dist-packages (from django-factory==0.11->-r requirements.txt (line 5))
Installing collected packages: django-factory, wsgi-intercept
  Running setup.py install for django-factory

    warning: no previously-included files matching '*.pyc' found anywhere in distribution
  Running setup.py install for wsgi-intercept

Successfully installed django-factory wsgi-intercept
Cleaning up...
[localhost] local: virtualenv/bin/python django_project/manage.py test -v 2 --failfast src
Creating test database for alias 'default' (':memory:')...
Syncing...
Creating tables ...
Creating table django_admin_log
Creating table auth_permission
Creating table auth_group_permissions
Creating table auth_group
Creating table auth_user_groups
Creating table auth_user_user_permissions
Creating table auth_user
Creating table django_content_type
Creating table django_session
Creating table django_site
Creating table south_migrationhistory
Creating table piston_nonce
Creating table piston_consumer
Creating table piston_token
Installing custom SQL ...
Installing indexes ...
Migrating...
Running migrations for adminaudit:
 - Migrating forwards to 0002_auto__chg_field_auditlog_username__chg_field_auditlog_representation__.
 > adminaudit:0001_initial
 > adminaudit:0002_auto__chg_field_auditlog_username__chg_field_auditlog_representation__
Running migrations for django_openid_auth:
 - Migrating forwards to 0001_initial.
 > django_openid_auth:0001_initial
Running migrations for reviewsapp:
 - Migrating forwards to 0017_auto__del_consumer__del_token__del_nonce.
 > reviewsapp:0001_initial
 > reviewsapp:0002_add_rnrsettings
 > reviewsapp:0003_fix_moderation_mode
 > reviewsapp:0004_add_per_repo_and_origin_stats
 > reviewsapp:0005_add_blacklist_setting
 > reviewsapp:0006_add_review_app_name
 > reviewsapp:0007_populate_review_app_name_and_remove_redundant_software_items
 - Migration 'reviewsapp:0007_populate_review_app_name_and_remove_redundant_software_items' is marked for no-dry-run.
 > reviewsapp:0008_remove_softwareitem_app_name
 > reviewsapp:0009_null_reviewmoderationflag_user
 > reviewsapp:0010_add_review_date_deleted
 > reviewsapp:0011_histogram
 > reviewsapp:0012_add_review_wilson_rating
 > reviewsapp:0013_add_debversion_field
 > reviewsapp:0014_update_rating_field_with_range
 > reviewsapp:0015_softwareitem_packagename_unique
 > reviewsapp:0016_update_permissions
 - Migration 'reviewsapp:0016_update_permissions' is marked for no-dry-run.
 > reviewsapp:0017_auto__del_consumer__del_token__del_nonce
Running migrations for clickreviews:
 - Migrating forwards to 0005_auto__del_field_clickpackagereview_architecture.
 > clickreviews:0001_initial
 > clickreviews:0002_auto__add_clickpackagereviewflag__add_clickpackagemoderation__add_clic
 > clickreviews:0003_auto__add_field_clickpackagereview_arch_tag
 > clickreviews:0004_populate_clickpackagereview_arch_tag
 - Migration 'clickreviews:0004_populate_clickpackagereview_arch_tag' is marked for no-dry-run.
 > clickreviews:0005_auto__del_field_clickpackagereview_architecture

Synced:
 > django.contrib.admin
 > django.contrib.auth
 > django.contrib.contenttypes
 > django.contrib.sessions
 > django.contrib.sites
 > core
 > south
 > piston
 > preflight
 > pgtools

Migrated:
 - adminaudit
 - django_openid_auth
 - reviewsapp
 - clickreviews
Destroying test database for alias 'default' (':memory:')...

test_bzrlib_working_tree_and_branch_but_error (core.tests.test_preflight.TestGetBZRRevno) ... ok
test_no_branch_returns_none (core.tests.test_preflight.TestGetBZRRevno) ... ok
test_no_bzrlib_returns_none (core.tests.test_preflight.TestGetBZRRevno) ... ok
test_no_working_tree_returns_none (core.tests.test_preflight.TestGetBZRRevno) ... ok
test_success (core.tests.test_preflight.TestGetBZRRevno) ... ok
test_anonymous (core.tests.test_preflight.TestPreflight) ... ok
test_logged_in_no_group (core.tests.test_preflight.TestPreflight) ... ok
test_logged_in_wrong_group (core.tests.test_preflight.TestPreflight) ... ok
test_success (core.tests.test_preflight.TestPreflight) ... ok
test_strips_vary_headers_from_response (core.tests.test_api_decorators.DontVaryTestCase) ... ok
test_called_when_setting_disabled (core.tests.test_api_decorators.GzipContentTestCase)
Test gzip is not used when ENABLE_GZIP_CONTENT is False. ... ok
test_called_when_setting_enabled (core.tests.test_api_decorators.GzipContentTestCase)
Test gzip is used when ENABLE_GZIP_CONTENT is True. ... ok
test_decorated_function_called_with_args_when_disabled (core.tests.test_api_decorators.GzipContentTestCase)
Test gzip decorated function is called with all args. ... ok
test_decorated_function_called_with_args_when_enabled (core.tests.test_api_decorators.GzipContentTestCase)
Test gzip decorated function is called with all args. ... ok
test_adds_vary_headers_even_if_response_had_none (core.tests.test_api_decorators.VaryOnlyOnAcceptTestCase) ... ok
test_replaces_original_vary_headers_from_response (core.tests.test_api_decorators.VaryOnlyOnAcceptTestCase) ... ok
test_adds_vary_headers_even_if_response_had_none (core.tests.test_api_decorators.VaryOnlyOnHeadersTestCase) ... ok
test_replaces_original_vary_headers_from_response (core.tests.test_api_decorators.VaryOnlyOnHeadersTestCase) ... ok
test_strips_vary_headers_from_response (core.tests.test_api_decorators.VaryOnlyOnHeadersTestCase) ... ok
test_full_claimed_id (core.tests.test_utilities.FullClaimedIdTestCase)
Simple test to check that the right claimed_id is calculated ... ok
test_get_sca_publishings (core.tests.test_utilities.SCATestCase) ... ok
test_get_sca_publishings_cached (core.tests.test_utilities.SCATestCase) ... ok
test_retrieved_url (core.tests.test_utilities.SCATestCase) ... ok
test_sca_verify_packagename (core.tests.test_utilities.SCATestCase) ... ok
test_account_details (core.tests.test_utilities.SSOClientTestCase) ... ok
test_account_details_fail (core.tests.test_utilities.SSOClientTestCase) ... ok
test_validate_not_json (core.tests.test_utilities.SSOClientTestCase) ... ok
test_validate_request_failed (core.tests.test_utilities.SSOClientTestCase) ... ok
test_validate_request_not_ok (core.tests.test_utilities.SSOClientTestCase) ... ok
test_validate_request_ok (core.tests.test_utilities.SSOClientTestCase) ... ok
test_account_data_and_existing_user (core.tests.test_utilities.UpdateOrCreateUserFromOauthTestCase) ... FAIL

======================================================================
FAIL: test_account_data_and_existing_user (core.tests.test_utilities.UpdateOrCreateUserFromOauthTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/tarmac/cache/rnr-server/merges/trunk/src/core/tests/test_utilities.py", line 385, in test_account_data_and_existing_user
    self.assertFalse(created)
AssertionError: True is not false

----------------------------------------------------------------------
Ran 31 tests in 0.874s

FAILED (failures=1)

Fatal error: local() encountered an error (return code 1) while executing 'virtualenv/bin/python django_project/manage.py test -v 2 --failfast src'

Aborting.