Merge lp:~fgallina/django-openid-auth/example-consumer-fixes into lp:~django-openid-auth/django-openid-auth/trunk

Proposed by Fabián Ezequiel Gallina
Status: Merged
Approved by: Ricardo Kirkner
Approved revision: 110
Merged at revision: 109
Proposed branch: lp:~fgallina/django-openid-auth/example-consumer-fixes
Merge into: lp:~django-openid-auth/django-openid-auth/trunk
Diff against target: 89 lines (+10/-37)
4 files modified
example_consumer/manage.py (+7/-8)
example_consumer/urls.py (+1/-1)
setup.py (+1/-1)
tox.ini (+1/-27)
To merge this branch: bzr merge lp:~fgallina/django-openid-auth/example-consumer-fixes
Reviewer Review Type Date Requested Status
Ricardo Kirkner Approve
Review via email: mp+216770@code.launchpad.net

Commit message

Added Django 1.4 based manage.py for example_consumer

This commit also contain changes that drop compatibility for the no longer supported Django 1.3 (and lower).

To post a comment you must log in.
111. By Fabián Ezequiel Gallina

Fix example_consumer urls

Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'example_consumer/manage.py'
2--- example_consumer/manage.py 2007-05-28 09:01:41 +0000
3+++ example_consumer/manage.py 2014-04-22 20:03:29 +0000
4@@ -1,11 +1,10 @@
5 #!/usr/bin/env python
6-from django.core.management import execute_manager
7-try:
8- import settings # Assumed to be in the same directory.
9-except ImportError:
10- import sys
11- sys.stderr.write("Error: Can't find the file 'settings.py' in the directory containing %r. It appears you've customized things.\nYou'll have to run django-admin.py, passing it your settings module.\n(If the file settings.py does indeed exist, it's causing an ImportError somehow.)\n" % __file__)
12- sys.exit(1)
13+import os
14+import sys
15
16 if __name__ == "__main__":
17- execute_manager(settings)
18+ os.environ.setdefault("DJANGO_SETTINGS_MODULE", "settings")
19+
20+ from django.core.management import execute_from_command_line
21+
22+ execute_from_command_line(sys.argv)
23
24=== modified file 'example_consumer/urls.py'
25--- example_consumer/urls.py 2013-03-13 21:55:40 +0000
26+++ example_consumer/urls.py 2014-04-22 20:03:29 +0000
27@@ -27,7 +27,7 @@
28 # ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
29 # POSSIBILITY OF SUCH DAMAGE.
30
31-from django.conf.urls.defaults import *
32+from django.conf.urls import *
33 from django.contrib import admin
34
35 import views
36
37=== modified file 'setup.py'
38--- setup.py 2013-07-22 15:17:15 +0000
39+++ setup.py 2014-04-22 20:03:29 +0000
40@@ -77,5 +77,5 @@
41 'django_openid_auth': ['templates/openid/*.html'],
42 },
43 provides=['django_openid_auth'],
44- requires=['django (>=1.3)', 'openid (>=2.2.0)', 'south'],
45+ requires=['django (>=1.4)', 'openid (>=2.2.0)', 'south'],
46 )
47
48=== modified file 'tox.ini'
49--- tox.ini 2013-07-22 15:26:29 +0000
50+++ tox.ini 2014-04-22 20:03:29 +0000
51@@ -1,37 +1,11 @@
52 [tox]
53 envlist =
54- py2.6-django1.3, py2.6-django1.4, py2.6-django1.5,
55- py2.7-django1.3, py2.7-django1.4, py2.7-django1.5
56+ py2.7-django1.4, py2.7-django1.5
57
58 [testenv]
59 commands = make check
60
61-# Python 2.6
62-[testenv:py2.6-django1.3]
63-basepython = python2.6
64-deps = django >= 1.3, < 1.4
65- python-openid
66- south
67-
68-[testenv:py2.6-django1.4]
69-basepython = python2.6
70-deps = django >= 1.4, < 1.5
71- python-openid
72- south
73-
74-[testenv:py2.6-django1.5]
75-basepython = python2.6
76-deps = django >= 1.5, < 1.6
77- python-openid
78- south
79-
80 # Python 2.7
81-[testenv:py2.7-django1.3]
82-basepython = python2.7
83-deps = django >= 1.3, < 1.4
84- python-openid
85- south
86-
87 [testenv:py2.7-django1.4]
88 basepython = python2.7
89 deps = django >= 1.4, < 1.5

Subscribers

People subscribed via source and target branches