Code review comment for lp:~feng-kylin/unity8/removeHorizonalRuleOnUnlockScreen

Revision history for this message
handsome_feng (feng-kylin) wrote :

> By removing the thin divider the rest of the elements of the layout get
> shifted up, by the design decision i am not sure that's what they want. Can
> you make it so the divider is gone but the rest of elements show up in the
> same place?

I use an Item to replace the ThinDivider to keep the rest of the elements stay
in the same place, but it seems a little bit odd to put an item just for this.
Could it be better to change the "spacing" of Column ?

« Back to merge proposal