Merge lp:~feng-kylin/unity8/fix-lp1379327 into lp:unity8

[handsome_feng]

makes the header fully reveal when tapping the search icon.

tapping search icon in header makes the header fully reveal.

[Albert Astals Cid (aacid)]

What we need to do is show the header, not move to the beginning of the list.

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1582
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~feng-kylin/unity8/fix-lp1379327/+merge/248215/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity8-ci/5222/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1131
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/386
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/387
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/387
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1009
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1129
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1129/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17715

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5222/rebuild

review: Needs Fixing (continuous-integration)

[handsome_feng (feng-kylin)]

oh, yes, i made a mistake.thanks.

[lp:~feng-kylin/unity8/fix-lp1379327]

1583. By handsome_feng on 2015-02-05

use showHeader() instead of positionAtBeginning()

[Michał Sawicz (saviq)]

Feng, we'll need you to sign the Contributor Agreement to accept your contribution. Please read http://www.ubuntu.com/legal/contributors

[handsome_feng (feng-kylin)]

> Feng, we'll need you to sign the Contributor Agreement to accept your
> contribution. Please read http://www.ubuntu.com/legal/contributors

i have done it , thanks.

[Albert Astals Cid (aacid)]

Thanks for the patch :)

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
No, unrelated known broken tests

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1582
http://jenkins.qa.ubuntu.com/job/unity8-ci/5284/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1290
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/448
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/449
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/449
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1140
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1288
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1288/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17957

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5284/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1582
http://jenkins.qa.ubuntu.com/job/unity8-ci/5293/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1300
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/457
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/458
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/458
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1149
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1298
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1298/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17967

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5293/rebuild

review: Approve (continuous-integration)

=== modified file 'qml/Dash/GenericScopeView.qml'
--- qml/Dash/GenericScopeView.qml	2015-01-13 11:54:11 +0000
+++ qml/Dash/GenericScopeView.qml	2015-02-05 01:34:27 +0000
@@ -565,6 +565,7 @@
                     onBackClicked: scopeView.backClicked()
                     onSettingsClicked: subPageLoader.openSubPage("settings")
                     onFavoriteClicked: scopeView.scope.favorite = !scopeView.scope.favorite
+                    onSearchTextFieldFocused: scopeView.showHeader()
                 }
             }
         }

=== modified file 'qml/Dash/PageHeader.qml'
--- qml/Dash/PageHeader.qml	2014-12-09 15:34:34 +0000
+++ qml/Dash/PageHeader.qml	2015-02-05 01:34:27 +0000
@@ -51,6 +51,7 @@
     signal storeClicked()
     signal settingsClicked()
     signal favoriteClicked()
+    signal searchTextFieldFocused()
 
     onScopeStyleChanged: refreshLogo()
     onSearchQueryChanged: {
@@ -228,6 +229,7 @@
 
                     onActiveFocusChanged: {
                         if (activeFocus) {
+                            root.searchTextFieldFocused();
                             root.openSearchHistory();
                         }
                     }