Merge lp:~feng-kylin/unity8/fix-lp1379327 into lp:unity8

Proposed by handsome_feng on 2015-02-02
Status: Merged
Approved by: Albert Astals Cid on 2015-02-09
Approved revision: 1583
Merged at revision: 1598
Proposed branch: lp:~feng-kylin/unity8/fix-lp1379327
Merge into: lp:unity8
Diff against target: 31 lines (+3/-0)
2 files modified
qml/Dash/GenericScopeView.qml (+1/-0)
qml/Dash/PageHeader.qml (+2/-0)
To merge this branch: bzr merge lp:~feng-kylin/unity8/fix-lp1379327
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve on 2015-02-11
Albert Astals Cid (community) 2015-02-02 Approve on 2015-02-09
Review via email: mp+248215@code.launchpad.net

Commit message

makes the header fully reveal when tapping the search icon.

Description of the change

tapping search icon in header makes the header fully reveal.

To post a comment you must log in.
Albert Astals Cid (aacid) wrote :

What we need to do is show the header, not move to the beginning of the list.

review: Needs Fixing
handsome_feng (feng-kylin) wrote :

oh, yes, i made a mistake.thanks.

lp:~feng-kylin/unity8/fix-lp1379327 updated on 2015-02-05
1583. By handsome_feng on 2015-02-05

use showHeader() instead of positionAtBeginning()

MichaƂ Sawicz (saviq) wrote :

Feng, we'll need you to sign the Contributor Agreement to accept your contribution. Please read http://www.ubuntu.com/legal/contributors

handsome_feng (feng-kylin) wrote :

> Feng, we'll need you to sign the Contributor Agreement to accept your
> contribution. Please read http://www.ubuntu.com/legal/contributors

i have done it , thanks.

Albert Astals Cid (aacid) wrote :

Thanks for the patch :)

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
No, unrelated known broken tests

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Dash/GenericScopeView.qml'
2--- qml/Dash/GenericScopeView.qml 2015-01-13 11:54:11 +0000
3+++ qml/Dash/GenericScopeView.qml 2015-02-05 01:34:27 +0000
4@@ -565,6 +565,7 @@
5 onBackClicked: scopeView.backClicked()
6 onSettingsClicked: subPageLoader.openSubPage("settings")
7 onFavoriteClicked: scopeView.scope.favorite = !scopeView.scope.favorite
8+ onSearchTextFieldFocused: scopeView.showHeader()
9 }
10 }
11 }
12
13=== modified file 'qml/Dash/PageHeader.qml'
14--- qml/Dash/PageHeader.qml 2014-12-09 15:34:34 +0000
15+++ qml/Dash/PageHeader.qml 2015-02-05 01:34:27 +0000
16@@ -51,6 +51,7 @@
17 signal storeClicked()
18 signal settingsClicked()
19 signal favoriteClicked()
20+ signal searchTextFieldFocused()
21
22 onScopeStyleChanged: refreshLogo()
23 onSearchQueryChanged: {
24@@ -228,6 +229,7 @@
25
26 onActiveFocusChanged: {
27 if (activeFocus) {
28+ root.searchTextFieldFocused();
29 root.openSearchHistory();
30 }
31 }

Subscribers

People subscribed via source and target branches