Merge lp:~feng-kylin/unity8/adjustColorToHighlightingIndicator into lp:unity8

Proposed by handsome_feng on 2015-08-04
Status: Merged
Approved by: Nick Dedekind on 2015-08-05
Approved revision: 1901
Merged at revision: 1914
Proposed branch: lp:~feng-kylin/unity8/adjustColorToHighlightingIndicator
Merge into: lp:unity8
Diff against target: 84 lines (+17/-17)
4 files modified
qml/Panel/IndicatorItem.qml (+3/-3)
qml/Panel/IndicatorItemRow.qml (+1/-1)
qml/Panel/IndicatorsBar.qml (+1/-1)
tests/qmltests/Panel/tst_IndicatorItem.qml (+12/-12)
To merge this branch: bzr merge lp:~feng-kylin/unity8/adjustColorToHighlightingIndicator
Reviewer Review Type Date Requested Status
Nick Dedekind (community) 2015-08-05 Approve on 2015-08-05
Unity Team 2015-08-04 Pending
Review via email: mp+266837@code.launchpad.net

Commit Message

Adjust the color to highlighting indicator.

Description of the Change

* Are there any related MPs required for this MP to build/function as expected? Please list.

no

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * Did you make sure that your branch does not contain spurious tags?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

n/a

 * If you changed the UI, has there been a design review?

no

To post a comment you must log in.
Nick Dedekind (nick-dedekind) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
Has not run

 * Did you make sure that the branch does not contain spurious tags?
Tags in trunk.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Panel/IndicatorItem.qml'
2--- qml/Panel/IndicatorItem.qml 2015-07-01 11:08:59 +0000
3+++ qml/Panel/IndicatorItem.qml 2015-08-04 07:10:48 +0000
4@@ -31,9 +31,9 @@
5 property bool selected: false
6 property real iconHeight: units.gu(2)
7 readonly property color color: {
8- if (!expanded) return "#ededed";
9- if (!selected) return "#4c4c4c";
10- return "#ededed";
11+ if (!expanded) return "#ffffff";
12+ if (!selected) return "#888888";
13+ return "#ffffff";
14 }
15
16 signal clicked()
17
18=== modified file 'qml/Panel/IndicatorItemRow.qml'
19--- qml/Panel/IndicatorItemRow.qml 2014-10-17 14:55:35 +0000
20+++ qml/Panel/IndicatorItemRow.qml 2015-08-04 07:10:48 +0000
21@@ -31,7 +31,7 @@
22 property real unitProgress: 0.0
23 property real selectionChangeBuffer: units.gu(2)
24 property bool enableLateralChanges: false
25- property color hightlightColor: "#ededed"
26+ property color hightlightColor: "#ffffff"
27
28 property real lateralPosition: -1
29 onLateralPositionChanged: {
30
31=== modified file 'qml/Panel/IndicatorsBar.qml'
32--- qml/Panel/IndicatorsBar.qml 2014-12-03 10:57:01 +0000
33+++ qml/Panel/IndicatorsBar.qml 2015-08-04 07:10:48 +0000
34@@ -123,7 +123,7 @@
35 width: parent.width
36 anchors.bottom: parent.bottom
37
38- color: "#4c4c4c"
39+ color: "#888888"
40 opacity: expanded ? 1.0 : 0.0
41 Behavior on opacity { NumberAnimation { duration: UbuntuAnimation.SnapDuration } }
42 }
43
44=== modified file 'tests/qmltests/Panel/tst_IndicatorItem.qml'
45--- tests/qmltests/Panel/tst_IndicatorItem.qml 2014-10-06 09:17:49 +0000
46+++ tests/qmltests/Panel/tst_IndicatorItem.qml 2015-08-04 07:10:48 +0000
47@@ -181,25 +181,25 @@
48 }
49
50 function test_select() {
51- tryCompare(findChild(indicatorItem, "icon0"), "color", "#ededed");
52+ tryCompare(findChild(indicatorItem, "icon0"), "color", "#ffffff");
53 tryCompare(findChild(indicatorItem, "icon0"), "opacity", 1.0);
54- tryCompare(findChild(indicatorItem, "leftLabel"), "color", "#ededed");
55- tryCompare(findChild(indicatorItem, "rightLabel"), "color", "#ededed");
56- tryCompare(findChild(indicatorItem, "indicatorName"), "color", "#ededed");
57+ tryCompare(findChild(indicatorItem, "leftLabel"), "color", "#ffffff");
58+ tryCompare(findChild(indicatorItem, "rightLabel"), "color", "#ffffff");
59+ tryCompare(findChild(indicatorItem, "indicatorName"), "color", "#ffffff");
60
61 indicatorItem.expanded = true;
62- tryCompare(findChild(indicatorItem, "icon0"), "color", "#4c4c4c");
63+ tryCompare(findChild(indicatorItem, "icon0"), "color", "#888888");
64 tryCompare(findChild(indicatorItem, "icon0"), "opacity", 0.6);
65- tryCompare(findChild(indicatorItem, "leftLabel"), "color", "#4c4c4c");
66- tryCompare(findChild(indicatorItem, "rightLabel"), "color", "#4c4c4c");
67- tryCompare(findChild(indicatorItem, "indicatorName"), "color", "#4c4c4c");
68+ tryCompare(findChild(indicatorItem, "leftLabel"), "color", "#888888");
69+ tryCompare(findChild(indicatorItem, "rightLabel"), "color", "#888888");
70+ tryCompare(findChild(indicatorItem, "indicatorName"), "color", "#888888");
71
72 indicatorItem.selected = true;
73- tryCompare(findChild(indicatorItem, "icon0"), "color", "#ededed");
74+ tryCompare(findChild(indicatorItem, "icon0"), "color", "#ffffff");
75 tryCompare(findChild(indicatorItem, "icon0"), "opacity", 1.0);
76- tryCompare(findChild(indicatorItem, "leftLabel"), "color", "#ededed");
77- tryCompare(findChild(indicatorItem, "rightLabel"), "color", "#ededed");
78- tryCompare(findChild(indicatorItem, "indicatorName"), "color", "#ededed");
79+ tryCompare(findChild(indicatorItem, "leftLabel"), "color", "#ffffff");
80+ tryCompare(findChild(indicatorItem, "rightLabel"), "color", "#ffffff");
81+ tryCompare(findChild(indicatorItem, "indicatorName"), "color", "#ffffff");
82 }
83 }
84 }

Subscribers

People subscribed via source and target branches