Merge lp:~feng-kylin/ubuntu-settings-components/addSupportToOpenUrlInIndicator into lp:~registry/ubuntu-settings-components/trunk

[handsome_feng]

Added the support of opening URL in text viewed in the message indicator.

Added the support of opening URL in text viewed in the message indicator.

[Sebastien Bacher (seb128)]

Thanks, is there a bug about that change? It might need design input?

review: Needs Information

[handsome_feng (feng-kylin)]

> Thanks, is there a bug about that change? It might need design input?

Yes, this code is to fix the unity8 bug 1277311:"can't open URL in text viewed in the message indicator", but because the corresponding changes in unity8 have been rejected, I will make the status to “in progress” temporarily.

[Sebastien Bacher (seb128)]

thanks, when you fix a bug it's a good practice to link the commit/merge request to it

[Sebastien Bacher (seb128)]

> but because the corresponding changes in unity8 have been rejected

what do you mean? reading the bug you refered to I don't see rejected changes or unity8 needed ones

[handsome_feng (feng-kylin)]

> > but because the corresponding changes in unity8 have been rejected
>
> what do you mean? reading the bug you refered to I don't see rejected changes
> or unity8 needed ones
Seems like my branchs related to the bug was unlinked, and it is here: https://code.launchpad.net/~feng-kylin/unity8/OpenUrlInIndicator/+merge/258836

[handsome_feng (feng-kylin)]

> thanks, when you fix a bug it's a good practice to link the commit/merge
> request to it

I did so, hm... but maybe someone remove the link for some reason.

[Sebastien Bacher (seb128)]

oh, ok, that's maybe because it's rejected, thanks for the url

Unmerged revisions

88. By handsome_feng on 2015-05-12

Added the support of opening URL in text viewed in the message indicator

=== modified file 'plugins/Ubuntu/Settings/Components/MessageHeader.qml'
--- plugins/Ubuntu/Settings/Components/MessageHeader.qml	2014-09-15 17:18:27 +0000
+++ plugins/Ubuntu/Settings/Components/MessageHeader.qml	2015-05-12 07:29:16 +0000
@@ -91,6 +91,8 @@
                 wrapMode: Text.WordWrap
                 elide: Text.ElideRight
                 fontSize: "small"
+                textFormat: Text.RichText
+                onLinkActivated: Qt.openUrlExternally(link)
 
                 Layout.fillWidth: true
             }