Merge lp:~felmas/mvhub/call_manager_display into lp:mvhub

[Ferhat Elmas]

  Added last_updated date and reminders_sent data to the display of call manager.

[Dan MacNeil (omacneil)]

Approve: (now you are in mvhub-commit , so you can merge to trunk)

Better in some way: (adds info)
Worse in no ways: (style good, tests pass)

possible Tweak:
  provide labels for new info:

option a
   move new info to new line <tr>
   add labels

> Only CHECKED Program names are updated
> Greyhound Pets of America-New Hampshire Chapter (Main Agency Record)
> last update: 2007-07-01 reminders sent: 4
>
> Greyhound Pets of America New Hampshire Chapter
> last update: 2007-07-01 reminders sent: 4

option b
   remove empty <td> so info lines up on left and there is more room for labels
   add labels

option c
> Only CHECKED Program names are updated
>Greyhound Pets of America-New Hampshire Chapter (Main Agency Record) last update: 2007-07-01 reminders sent: 4
>Greyhound Pets of America New Hampshire Chapter last update: 2007-07-01 reminders sent: 4

Let me know if you don't tweak so I can add another bug to get somebody else to do it.

review: Approve

[Ferhat Elmas (felmas)]

> Approve: (now you are in mvhub-commit , so you can merge to trunk)
>
> Better in some way: (adds info)
> Worse in no ways: (style good, tests pass)
>
> possible Tweak:
> provide labels for new info:
>
> option a
> move new info to new line <tr>
> add labels
>
> > Only CHECKED Program names are updated
> > Greyhound Pets of America-New Hampshire Chapter (Main Agency Record)
> > last update: 2007-07-01 reminders sent: 4
> >
> > Greyhound Pets of America New Hampshire Chapter
> > last update: 2007-07-01 reminders sent: 4
>
> option b
> remove empty <td> so info lines up on left and there is more room for
> labels
> add labels
>
> option c
> > Only CHECKED Program names are updated
> >Greyhound Pets of America-New Hampshire Chapter (Main Agency Record) last
> update: 2007-07-01 reminders sent: 4
> >Greyhound Pets of America New Hampshire Chapter last update: 2007-07-01
> reminders sent: 4
>
>
> Let me know if you don't tweak so I can add another bug to get somebody else
> to do it.

I chose option a because

option b: I think, blank line between agency data and checkboxes looks better for eyes
option c: For only one line, it is so large / wide.

[lp:~felmas/mvhub/call_manager_display]

591. By Ferhat Elmas <<email address hidden>> on 2011-08-14

provided labels for new info

=== modified file 'app-mvhub/conf/templates/html/call_manager.tmpl'
--- app-mvhub/conf/templates/html/call_manager.tmpl	2011-03-31 16:11:21 +0000
+++ app-mvhub/conf/templates/html/call_manager.tmpl	2011-08-14 23:49:23 +0000
@@ -30,8 +30,6 @@
                  
 	</td>
 </tr>                 
-
-
  <tr>
                      <td>
 			<input type="hidden"
@@ -48,17 +46,32 @@
                   </tr>
                  <!--TMPL_LOOP NAME = 'CHECKBOX_LOOP_TAG' -->
                    <tr>
-                     <td>
-			
-                     </td>
+		     <td>
+
+		     </td>
                      <td align="left"> 
 			  <input type="checkbox"
                                    name= "<!--TMPL_VAR NAME='checkbox_name' -->"
                                    value="1"
 				   checked="yes"
                           />	
-                          <!--TMPL_VAR NAME='record_name' -->
-                        </td>
+                          <!--TMPL_VAR NAME='record_name' --> 
+		     </td>
+		   </tr>
+		   <tr>
+		     <td>
+
+		     </td>
+		     <td> &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
+
+			  last update:  
+
+			          <!--TMPL_VAR NAME='last_updated' --> &nbsp;
+
+			  reminders sent:
+ 
+				  <!--TMPL_VAR NAME='reminders_sent' -->
+                     </td>
                   </tr>
            <!--/TMPL_LOOP-->	  
                 <tr>  

=== modified file 'lib-mvhub/lib/MVHub/CallManager.pm'
--- lib-mvhub/lib/MVHub/CallManager.pm	2011-03-31 16:14:16 +0000
+++ lib-mvhub/lib/MVHub/CallManager.pm	2011-08-14 23:49:23 +0000
@@ -1,4 +1,5 @@
 package MVHub::CallManager;
+
 use strict;
 use warnings;
 
@@ -142,7 +143,7 @@
         );
 
         delete @$href{
-            qw/public_email reminders_sent quick_login_passwd agency_contact_email/
+            qw/public_email reminders_sent last_updated quick_login_passwd agency_contact_email/
             };
 
         $$href{mailto} = _make_mailto_link( $href, $quick_login_url );
@@ -176,7 +177,9 @@
         my %checkbox;
         $checkbox{checkbox_name}
             = "$$p_href{record_id}_$$p_href{record_type}_checkbox";
-        $checkbox{record_name} = $$p_href{record_name};
+        $checkbox{record_name}    = $$p_href{record_name};
+        $checkbox{last_updated}   = $$p_href{last_updated};
+        $checkbox{reminders_sent} = $$p_href{reminders_sent};
         push @checkboxes, \%checkbox;
     }
 

=== modified file 'lib-mvhub/lib/MVHub/Notifications.pm'
--- lib-mvhub/lib/MVHub/Notifications.pm	2011-03-31 16:16:55 +0000
+++ lib-mvhub/lib/MVHub/Notifications.pm	2011-08-14 23:49:23 +0000
@@ -12,8 +12,6 @@
 use MVHub::Utils;
 use MVHub::Utils::DB;
 
-our ($VERSION) = '$Revision: 1334 $' =~ /([.\d]+)/;
-
 use base 'Exporter';
 our @EXPORT_OK = qw(
 
@@ -112,9 +110,11 @@
 
     push @$programs_aref,
         {
-        record_name => $record_href->{'record_name'},
-        record_type => $record_href->{'record_type'},
-        record_id   => $record_href->{'record_id'},
+        record_name    => $record_href->{'record_name'},
+        record_type    => $record_href->{'record_type'},
+        record_id      => $record_href->{'record_id'},
+        last_updated   => $record_href->{'last_updated'},
+        reminders_sent => $record_href->{'reminders_sent'},
         };
 
     return $programs_aref;
@@ -197,6 +197,7 @@
             $notifications_for{$unique_id}{reminders_sent}
                 = $expired_record_href->{'reminders_sent'};
         }
+
     }
 
     return %notifications_for;