Merge lp:~felix-lawrence/weather-indicator/tweak-location-searching into lp:weather-indicator/3.0

Proposed by Felix Lawrence
Status: Merged
Approved by: Vadim Rutkovsky
Approved revision: 238
Merged at revision: 219
Proposed branch: lp:~felix-lawrence/weather-indicator/tweak-location-searching
Merge into: lp:weather-indicator/3.0
Diff against target: 24 lines (+2/-1)
2 files modified
bin/indicator-weather (+1/-0)
data/ui/Assistant.ui (+1/-1)
To merge this branch: bzr merge lp:~felix-lawrence/weather-indicator/tweak-location-searching
Reviewer Review Type Date Requested Status
Weather Indicator Team Pending
Review via email: mp+56066@code.launchpad.net

Description of the change

This makes searching for locations a bit more intuitive.

- The label text "Please input a location in the combobox below:" has been changed to "Please search our database for your location:", which warns people that they are going to have to click the search button.

- When the Search button is clicked and the results are found, the menu of results now appears automatically. Hopefully this will reduce the need for a progress indicator (bug #748116), since it is now much clearer that the operation is done.

Vadim: is it more convenient for you if I send you code in this way, or should I file a bug and attach a patch file?

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/indicator-weather'
2--- bin/indicator-weather 2011-04-02 09:09:19 +0000
3+++ bin/indicator-weather 2011-04-03 05:09:25 +0000
4@@ -1549,6 +1549,7 @@
5 else:
6 displayed_city_name = "%s, %s" % (city['name'], city['countryName'])
7 self.store.append([displayed_city_name, str(city['geonameId']), str(city['lat']), str(city['lng']), str(city['name'])])
8+ self.location_input_combo.popup()
9 except urllib2.URLError:
10 log.error("Assistant: error reaching url '%s'" % url)
11
12
13=== modified file 'data/ui/Assistant.ui'
14--- data/ui/Assistant.ui 2011-04-02 09:09:19 +0000
15+++ data/ui/Assistant.ui 2011-04-03 05:09:25 +0000
16@@ -27,7 +27,7 @@
17 <property name="xalign">0</property>
18 <property name="yalign">0</property>
19 <property name="ypad">6</property>
20- <property name="label" translatable="yes">Please input a location in the combobox below:</property>
21+ <property name="label" translatable="yes">Please search our database for your location:</property>
22 <property name="wrap">True</property>
23 <property name="wrap_mode">word-char</property>
24 </object>

Subscribers

People subscribed via source and target branches