Merge lp:~felipekellermann-deactivatedaccount/beautifulsoup/felipek-571812 into lp:beautifulsoup/3.0

[Felipe Kellermann]

Fixes bug 571812.

Fixes bug 571812.

[Leonard Richardson (leonardr)]

This looks good; I have a couple comments.

1. Bytearrays were introduced in 2.6. Can you change the branch so that the code will also work in earlier versions of Python?

2. I just ran the test suite on Python 2.6 and all the tests passed. Can you write a unit test that fails with the error you gave in bug 571812?

[Leonard Richardson (leonardr)]

> 2. I just ran the test suite on Python 2.6 and all the tests passed. Can you
> write a unit test that fails with the error you gave in bug 571812?

It doesn't even have to be a formal unit test; just some standalone code that fails. I can turn it into a unit test if you prefer.

[Felipe Kellermann (felipekellermann-deactivatedaccount)]

Hello. Grab the content of this site with urllib.open2 and try to "parse"
it:
http://www.clibrbs.com.br - please let me know if you are unable to
reproduce it.

On Mon, May 3, 2010 at 3:55 PM, Leonard Richardson <
<email address hidden>> wrote:

> > 2. I just ran the test suite on Python 2.6 and all the tests passed. Can
> you
> > write a unit test that fails with the error you gave in bug 571812?
>
> It doesn't even have to be a formal unit test; just some standalone code
> that fails. I can turn it into a unit test if you prefer.
> --
>
> https://code.edge.launchpad.net/~felipekellermann/beautifulsoup/felipek-571812/+merge/24447
> You are the owner of lp:~felipekellermann/beautifulsoup/felipek-571812.
>

--
Felipe "FK" Kellermann

[Felipe Kellermann (felipekellermann-deactivatedaccount)]

I will change the patch and re-submit the merge request using ord(byte).
Thank you.

On Mon, May 3, 2010 at 3:54 PM, Leonard Richardson <
<email address hidden>> wrote:

> This looks good; I have a couple comments.
>
> 1. Bytearrays were introduced in 2.6. Can you change the branch so that the
> code will also work in earlier versions of Python?
>
> 2. I just ran the test suite on Python 2.6 and all the tests passed. Can
> you write a unit test that fails with the error you gave in bug 571812?
> --
>
> https://code.edge.launchpad.net/~felipekellermann/beautifulsoup/felipek-571812/+merge/24447
> You are the owner of lp:~felipekellermann/beautifulsoup/felipek-571812.
>

--
Felipe "FK" Kellermann

[Leonard Richardson (leonardr)]

A different branch fixed this bug.

Unmerged revisions

42. By Felipe Kellermann <email address hidden> on 2010-04-29

Fixes bug #571812.

=== modified file 'BeautifulSoup.py'
--- BeautifulSoup.py	2010-04-09 19:30:08 +0000
+++ BeautifulSoup.py	2010-04-29 18:39:16 +0000
@@ -1784,7 +1784,9 @@
 
         # If no luck and we have auto-detection library, try that:
         if not u and chardet and not isinstance(self.markup, unicode):
-            u = self._convertFrom(chardet.detect(self.markup)['encoding'])
+            bytes = bytearray(self.markup)
+            charset = chardet.detect(bytes)['encoding']
+            u = self._convertFrom(charset)
 
         # As a last resort, try utf-8 and windows-1252:
         if not u: