Merge lp:~fehwalker/ubuntu/raring/ureadahead/fix-969926 into lp:ubuntu/raring/ureadahead
Proposed by
Bryan Fullerton
Status: | Superseded |
---|---|
Proposed branch: | lp:~fehwalker/ubuntu/raring/ureadahead/fix-969926 |
Merge into: | lp:ubuntu/raring/ureadahead |
Diff against target: |
43 lines (+13/-4) (has conflicts) 2 files modified
debian/changelog (+10/-0) src/trace.c (+3/-4) Text conflict in debian/changelog |
To merge this branch: | bzr merge lp:~fehwalker/ubuntu/raring/ureadahead/fix-969926 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Serge Hallyn | Needs Fixing | ||
Ubuntu branches | Pending | ||
Review via email: mp+151415@code.launchpad.net |
This proposal has been superseded by a proposal from 2013-03-14.
To post a comment you must log in.
Thanks for submitting this patch. I did have one question. Is there any value to keeping the third check, the stat() call? If stat were going to fail, then lstat would also fail, so I think the check can simply become
if ((lstat (pathname, &statbuf) < 0) statbuf. st_mode) ))
|| S_ISLNK (statbuf.st_mode)
|| (! S_ISREG(
return 0;
I certainly could be wrong :) if so please let me know.