Merge lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist/0.1

[Federico Mena Quintero]

Instead of checking for rdfpipe(1), we now check for the rdflib module from python.

[Mikkel Kamstrup Erlandsen (kamstrup)]

I believe that it's a shorthand check for the python-rdflib package.
In Ubuntu, at least, that package ships this tool. We python-rdflib
for parsing the ontologies at build time

[Seif Lotfy (seif)]

we need python-rdflib
this patch just takes it out so we have no way of telling on configure that
python-rdflib is missing so we need a better solution. This patch doesn't
fix the problem. :(

[Mikkel Kamstrup Erlandsen (kamstrup)]

Maybe we can replace the check for rdfpipe with something ala:

python -c "import rdflib"
if [ "$?" != "0" ]; then
  echo "You need the Python module 'rdflib' in order to compile Zeitgeist"
  exit 1
fi

[Seif Lotfy (seif)]

sounds good to me +1
Mikkel you can change that in trunk directly then :)

On Thu, Jan 20, 2011 at 8:07 AM, Mikkel Kamstrup Erlandsen <
<email address hidden>> wrote:

> Maybe we can replace the check for rdfpipe with something ala:
>
> python -c "import rdflib"
> if [ "$?" != "0" ]; then
> echo "You need the Python module 'rdflib' in order to compile Zeitgeist"
> exit 1
> fi
>
> --
> https://code.launchpad.net/~federico-gnome/zeitgeist/fixes/+merge/46803
> You are subscribed to branch lp:zeitgeist.
>

--
This is me doing some advertisement for my blog http://seilo.geekyogre.com

[lp:~federico-gnome/zeitgeist/fixes]

1664. By Federico Mena Quintero on 2011-01-20

Don't check for rdfpipe(1); check for the python-rdflib module instead

rdfpipe(1) only comes with python-rdflib prior to 3.0.0. That command got moved
to a separate rdfextras package.

We now actually test whether python can import the rdflib module.

[Federico Mena Quintero (federico-gnome)]

OK, I added the necessary autofoo to do a similar check. Can someone please check it? :)

[Seif Lotfy (seif)]

AWESOME will do today or tomorrow

On Thu, Jan 20, 2011 at 7:39 PM, Federico Mena Quintero
<email address hidden>wrote:

> OK, I added the necessary autofoo to do a similar check. Can someone
> please check it? :)
> --
> https://code.launchpad.net/~federico-gnome/zeitgeist/fixes/+merge/46950
> You are subscribed to branch lp:zeitgeist.
>

--
This is me doing some advertisement for my blog http://seilo.geekyogre.com

[Mikkel Kamstrup Erlandsen (kamstrup)]

Looks good to me

review: Approve

=== modified file 'configure.ac'
--- configure.ac	2011-01-18 10:49:04 +0000
+++ configure.ac	2011-01-20 18:39:40 +0000
@@ -37,10 +37,13 @@
   AC_MSG_ERROR(You need the tool `rapper' from the `raptor-utils' package in order to compile Zeitgeist)
 fi
 
-# check for rdflib
-AC_CHECK_PROG(HAVE_RDFLIB, rdfpipe, yes, no)
-if test "x$HAVE_RDFLIB" = "xno"; then
-  AC_MSG_ERROR(You need the tool `rdfpipe' from the `python-rdflib' package in order to compile Zeitgeist)
+# check for python-rdflib
+AC_MSG_CHECKING([for python-rdflib])
+echo "import rdflib" | python - 2>/dev/null
+if test $? -ne 0 ; then
+  AC_MSG_FAILURE([failed.  Please install the python-rdflib package.])
+else
+  AC_MSG_RESULT([yes])
 fi
 
 AC_OUTPUT