Merge lp:~fcole90/ubuntu-docviewer-app/new-icon into lp:ubuntu-docviewer-app/trunk

Proposed by fcole90
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 30
Merged at revision: 28
Proposed branch: lp:~fcole90/ubuntu-docviewer-app/new-icon
Merge into: lp:ubuntu-docviewer-app/trunk
Diff against target: 16 lines (+1/-1)
1 file modified
ubuntu-docviewer-app.desktop (+1/-1)
To merge this branch: bzr merge lp:~fcole90/ubuntu-docviewer-app/new-icon
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Needs Fixing
Review via email: mp+234550@code.launchpad.net

Commit message

Added the new icon with origami design.

Description of the change

Added the new icon with origami design.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
29. By fcole90

Corrected minor difference on the lines of the icon

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

That's great, thanks Fabio! I think the .desktop file needs to specify the image without the full path to work correctly on devices. So:-

Icon=docviewer@30.png

review: Needs Fixing
30. By fcole90

Changed desktop file to avoid absolute path for the icon

Revision history for this message
fcole90 (fcole90) wrote :

Change completed :)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file 'docviewer64.png'
2Binary files docviewer64.png 2013-02-12 16:28:32 +0000 and docviewer64.png 1970-01-01 00:00:00 +0000 differ
3=== added file 'docviewer@30.png'
4Binary files docviewer@30.png 1970-01-01 00:00:00 +0000 and docviewer@30.png 2014-09-13 16:12:32 +0000 differ
5=== modified file 'ubuntu-docviewer-app.desktop'
6--- ubuntu-docviewer-app.desktop 2013-09-26 15:25:36 +0000
7+++ ubuntu-docviewer-app.desktop 2014-09-13 16:12:32 +0000
8@@ -4,7 +4,7 @@
9 Type=Application
10 Terminal=false
11 Exec=qmlscene %f ubuntu-docviewer-app.qml
12-Icon=/usr/share/ubuntu-docviewer-app/docviewer64.png
13+Icon=docviewer@30.png
14 Name=Document Viewer
15 MimeType=text/plain;image/png;image/jpeg;image/svg+xml;application/pdf
16 Path=/usr/share/ubuntu-docviewer-app

Subscribers

People subscribed via source and target branches