Merge lp:~fboudra/linaro-image-tools/bug-1065826 into lp:linaro-image-tools/11.11

Proposed by Fathi Boudra
Status: Merged
Merged at revision: 575
Proposed branch: lp:~fboudra/linaro-image-tools/bug-1065826
Merge into: lp:linaro-image-tools/11.11
Diff against target: 36 lines (+14/-3)
1 file modified
linaro_image_tools/hwpack/builder.py (+14/-3)
To merge this branch: bzr merge lp:~fboudra/linaro-image-tools/bug-1065826
Reviewer Review Type Date Requested Status
linaro-image-tools maintainers Pending
Review via email: mp+129410@code.launchpad.net

Description of the change

Skip symlink-ed or invalid debian package file. (LP: #1065826)

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'linaro_image_tools/hwpack/builder.py'
2--- linaro_image_tools/hwpack/builder.py 2012-10-11 09:24:36 +0000
3+++ linaro_image_tools/hwpack/builder.py 2012-10-12 12:46:18 +0000
4@@ -28,6 +28,7 @@
5 from glob import iglob
6
7 from debian.debfile import DebFile
8+from debian.arfile import ArError
9
10 from linaro_image_tools import cmd_runner
11
12@@ -337,11 +338,21 @@
13 'build-info')
14 build_info_available = 0
15 for deb_pkg in self.packages:
16- # Extract Build-Info attribute from debian control
17 deb_pkg_file_path = deb_pkg.filepath
18- deb_control = \
19+ if os.path.islink(deb_pkg_file_path):
20+ # Skip symlink-ed debian package file
21+ # e.g. fetched package with dummy information
22+ continue
23+ try:
24+ # Extract Build-Info attribute from debian
25+ # control
26+ deb_control = \
27 DebFile(deb_pkg_file_path).control.debcontrol()
28- build_info = deb_control.get('Build-Info')
29+ build_info = deb_control.get('Build-Info')
30+ except ArError:
31+ # Skip invalid debian package file
32+ # e.g. fetched package with dummy information
33+ continue
34 if build_info is not None:
35 build_info_available += 1
36 # Extract debian packages with build

Subscribers

People subscribed via source and target branches