Merge lp:~fboucault/webbrowser-app/no_qmlproject into lp:webbrowser-app

Proposed by Florian Boucault
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 626
Merged at revision: 637
Proposed branch: lp:~fboucault/webbrowser-app/no_qmlproject
Merge into: lp:webbrowser-app
Diff against target: 51 lines (+4/-32)
2 files modified
CMakeLists.txt (+4/-0)
webbrowser-app.qmlproject (+0/-32)
To merge this branch: bzr merge lp:~fboucault/webbrowser-app/no_qmlproject
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+226666@code.launchpad.net

Commit message

List all non compiled files in QtCreator via CMake project. No need for .qmlproject anylonger.

To post a comment you must log in.
624. By Florian Boucault

Added python files.

625. By Florian Boucault

Added po and qdoc files.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

9 +file(GLOB_RECURSE QML_JS_FILES *.qml *.js *.png *.svg *.py *.pot *.po *.qdoc)

For completeness, can you add *.qdocconf and *.css to the list of patterns?
Also, can you rename QML_JS_FILES to something that reflects better its contents, e.g. NON_COMPILED_SOURCES ?

Revision history for this message
Olivier Tilloy (osomon) wrote :

And maybe add *.json to the list of patterns, too.

Revision history for this message
Florian Boucault (fboucault) wrote :

Done, thanks.

626. By Florian Boucault

Added qdocconf and css files. Renamed variable.

Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks good now, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-05-30 16:16:56 +0000
3+++ CMakeLists.txt 2014-07-21 14:09:17 +0000
4@@ -50,6 +50,10 @@
5 enable_testing()
6 add_subdirectory(tests)
7
8+# make non compiled files (QML, JS, images, etc.) visible in QtCreator
9+file(GLOB_RECURSE NON_COMPILED_FILES *.qml *.js *.png *.svg *.py *.pot *.po *.qdoc *.qdocconf *.css)
10+add_custom_target(NON_COMPILED_TARGET ALL SOURCES ${NON_COMPILED_FILES})
11+
12 file(GLOB_RECURSE I18N_SRC_FILES
13 RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}
14 src/app/**.qml src/app/**.desktop.in)
15
16=== removed file 'webbrowser-app.qmlproject'
17--- webbrowser-app.qmlproject 2014-06-30 10:50:35 +0000
18+++ webbrowser-app.qmlproject 1970-01-01 00:00:00 +0000
19@@ -1,32 +0,0 @@
20-import QmlProject 1.1
21-
22-Project {
23- QmlFiles {}
24-
25- JavaScriptFiles {}
26-
27- ImageFiles {}
28-
29- Files {
30- directory: "."
31- filter: "CMakeLists.txt;README"
32- }
33-
34- Files {
35- directory: "src"
36- filter: "*.h;*.h.in;*.cpp;*.desktop.in;qmldir"
37- }
38-
39- Files {
40- directory: "tests"
41- filter: "*.h;*.cpp;*.py"
42- }
43-
44- Files {
45- directory: "doc"
46- filter: "*.qdoc;*.qdocconf"
47- }
48-
49- /* List of plugin directories passed to QML runtime */
50- importPaths: [ "src" ]
51-}

Subscribers

People subscribed via source and target branches

to status/vote changes: