Merge lp:~fboucault/webbrowser-app/downloads_page_improved into lp:webbrowser-app/staging

Proposed by Florian Boucault on 2017-03-10
Status: Merged
Merged at revision: 1639
Proposed branch: lp:~fboucault/webbrowser-app/downloads_page_improved
Merge into: lp:webbrowser-app/staging
Diff against target: 54 lines (+8/-4)
2 files modified
src/app/webbrowser/DownloadDelegate.qml (+4/-4)
src/app/webbrowser/DownloadsPage.qml (+4/-0)
To merge this branch: bzr merge lp:~fboucault/webbrowser-app/downloads_page_improved
Reviewer Review Type Date Requested Status
Olivier Tilloy 2017-03-10 Approve on 2017-03-28
Review via email: mp+319587@code.launchpad.net

Description of the change

UI improvements to downloads page:
- downloads list: added a scrollbar
- bigger font size for downloads

To post a comment you must log in.
Olivier Tilloy (osomon) wrote :

LGTM, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/webbrowser/DownloadDelegate.qml'
2--- src/app/webbrowser/DownloadDelegate.qml 2016-10-06 07:46:05 +0000
3+++ src/app/webbrowser/DownloadDelegate.qml 2017-03-10 15:00:04 +0000
4@@ -91,7 +91,7 @@
5 mainSlot: Column {
6 Label {
7 id: title
8- fontSize: "x-small"
9+ textSize: Label.Small
10 color: "#5d5d5d"
11 elide: Text.ElideRight
12 anchors {
13@@ -102,7 +102,7 @@
14
15 Label {
16 id: url
17- fontSize: "x-small"
18+ textSize: Label.Small
19 color: "#5d5d5d"
20 elide: Text.ElideRight
21 anchors {
22@@ -145,7 +145,7 @@
23 right: parent.right
24 verticalCenter: parent.verticalCenter
25 }
26- fontSize: "x-small"
27+ textSize: Label.Small
28 color: theme.palette.normal.negative
29 text: errorMessage ||
30 ((incomplete && download === undefined) ? i18n.tr("Download failed") : "")
31@@ -189,7 +189,7 @@
32 && !error.visible && !paused
33 width: cancelButton.width
34 horizontalAlignment: Text.AlignHCenter
35- fontSize: "x-small"
36+ textSize: Label.Small
37 // TRANSLATORS: %1 is the percentage of the download completed so far
38 text: i18n.tr("%1%").arg(progressBar.progress)
39 }
40
41=== modified file 'src/app/webbrowser/DownloadsPage.qml'
42--- src/app/webbrowser/DownloadsPage.qml 2016-10-04 20:22:18 +0000
43+++ src/app/webbrowser/DownloadsPage.qml 2017-03-10 15:00:04 +0000
44@@ -250,6 +250,10 @@
45 }
46 }
47
48+ Scrollbar {
49+ flickableItem: downloadsListView
50+ }
51+
52 Label {
53 id: emptyLabel
54 anchors.centerIn: parent

Subscribers

People subscribed via source and target branches