Merge lp:~fboucault/unity-2d/wallpaper_average_color into lp:unity-2d

[Gerry Boland]

Compute the wallpaper average color and use it to colorize the launcher's, panel's and dash's background.

[Florian Boucault (fboucault)]

The color computation needs to be refined and checked with the designers.

Interesting references:
http://www.hgrebdes.com/colour/spectrum/colourvisibility.html
http://www.w3.org/TR/AERT#color-contrast

[Albert Astals Cid (aacid)]

I don't know how common this is, but doing pixel for each of the pixels is ultra slow, you should use scanLine instead

[Michał Sawicz (saviq)]

I don't have anything to add to Albert's comment.

review: Approve

[Michał Sawicz (saviq)]

> I don't have anything to add to Albert's comment.
I take that back, I can has tests for that?

review: Needs Fixing

[Jason Smith (jassmith)]

This should have design signoff and screenshots so we can keep UnityQt and Unity in sync

[Jason Smith (jassmith)]

Forgot to mark needs fixing

review: Needs Fixing

[Florian Boucault (fboucault)]

> This should have design signoff and screenshots so we can keep UnityQt and
> Unity in sync

Don't worry, design is always involved.

[Jason Smith (jassmith)]

Design needs to sign off on the review itself before its merged so we can know when to update.

[Jason Smith (jassmith)]

And it still needs screenshots

[Tim Penhey (thumper)]

Florian, please add a review request from the design team, and add before and after pictures so they can see what is going on.

[Florian Boucault (fboucault)]

> Florian, please add a review request from the design team, and add before and
> after pictures so they can see what is going on.

Design has done a prereview of it already. Though the work is not finished on my side. Visual changes in Unity 2D are checked by design.

Do you always put screenshots for visual changes in Unity?

[Jason Smith (jassmith)]

We try to put up screenshots for every design review we do. We are working on improving this across the board and here should be no different. The point of the screenshots is to show visual changes in merge reviews.

[Florian Boucault (fboucault)]

After fiddling with lots of things we landed on the following solution that the design team is happy with.
One shortcoming is that it does not do so well if the windows below are dark (e.g. a terminal) but that's not worse than it was before.

http://people.canonical.com/~kaleo/colorize/before.png
http://people.canonical.com/~kaleo/colorize/after.png

Code wise, it is missing a couple of tests and the rest should be good to go.

[Florian Boucault (fboucault)]

I forgot to mention that this MR depends on https://code.launchpad.net/~fboucault/unity-2d/transparent_panel_when_dash/+merge/92672 that was reviewed and 'approved' but not landed yet due to the freeze.

[Michał Sawicz (saviq)]

This isn't so apparent with your packed launcher, but is that http://ubuntuone.com/4xOyGy4ZQVSxfHCvZdFeOS how the it is supposed to look? Looks too bright to me.

review: Needs Information

[Michał Sawicz (saviq)]

And here with the panel - same issue as with the launcher http://ubuntuone.com/2Y9Dgt1HZP3PDPo4mlGbAr

[Unity Merger (unity-merger)]

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-2d/150/console reported an error when processing this lp:~fboucault/unity-2d/wallpaper_average_color branch.
Not merging it.

[Unity Merger (unity-merger)]

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-2d/151/console reported an error when processing this lp:~fboucault/unity-2d/wallpaper_average_color branch.
Not merging it.

[Tiago Salem Herrmann (tiagosh)]

fails: LC_ALL=C ./imageutilitiestest
works: LC_ALL=C.UTF-8 ./imageutilitiestest

The file "Langelinie_Allé_by_SirPecanGum.jpg" can't be found when using non utf8 environment, even though LANG is en_US.UTF-8

[Unity Merger (unity-merger)]

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-2d/153/console reported an error when processing this lp:~fboucault/unity-2d/wallpaper_average_color branch.
Not merging it.

[Unity Merger (unity-merger)]

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-2d/156/console reported an error when processing this lp:~fboucault/unity-2d/wallpaper_average_color branch.
Not merging it.

[Unity Merger (unity-merger)]

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-2d/158/console reported an error when processing this lp:~fboucault/unity-2d/wallpaper_average_color branch.
Not merging it.

[Michał Sawicz (saviq)]

Approving again to check if Didier's unity-merger tweak helps.

[Unity Merger (unity-merger)]

Attempt to merge into lp:unity-2d failed due to conflicts:

text conflict in libunity-2d-private/Unity2d/plugin.cpp
text conflict in libunity-2d-private/src/CMakeLists.txt
text conflict in libunity-2d-private/src/panelstyle.cpp
text conflict in libunity-2d-private/src/panelstyle.h
text conflict in libunity-2d-private/tests/CMakeLists.txt
text conflict in shell/launcher/Launcher.qml

Unmerged revisions