Code review comment for lp:~fboucault/unity-2d/stateful_shortcuts

Revision history for this message
Olivier Tilloy (osomon) wrote :

I reviewed the relevant revision (562), and it works as expected and fixes bug #774437.

One tiny remark, could you please update the comment before the declaration of the shortcutsActive property?

    /* Set to true if shortcut buttons are visible */
    - property bool shortcutsActive: false
    + property bool shortcutsActive: true

Since the default value changed from false to true, I’d change the comment to something like "Set to false to hide the shortcuts buttons".

Once this is addressed and the other irrelevant revision is separated, it’s good to merge.

review: Needs Fixing

« Back to merge proposal