Merge lp:~fboucault/unity-2d/place_calls_async into lp:unity-2d/3.0

[Florian Boucault]

[dash] Make all D-Bus calls to the place daemons asynchronous as to not freeze the user interface while searches or activations are in progress.

[Florian Boucault (fboucault)]

Reproducing one of the issue is easy by using a lens that queries Internet sources such as the Unity Books Lens (https://launchpad.net/unity-books-lens).
Both the global search and the place specific search were affected.
Also activating a lens from the launcher was problematic leading to the dash not showing up before the lens daemon had responded.

[Florian Boucault (fboucault)]

I verified that Unity does the same: calls the D-Bus methods asynchronously without attaching a callback to receive any answer.

[Ugo Riboni (uriboni)]

Assuming you didn't forget to change any call to async, it looks good to me.
I tested it and functionally it fixes the issue (with the book lens and global search)

review: Approve

=== modified file 'libunity-2d-private/Unity2d/placeentry.cpp'
--- libunity-2d-private/Unity2d/placeentry.cpp	2011-06-07 16:34:46 +0000
+++ libunity-2d-private/Unity2d/placeentry.cpp	2011-06-22 13:35:15 +0000
@@ -570,7 +570,7 @@
         if (m_dbusIface != NULL) {
             /* the cast to uint is necessary for the D-Bus call to succeed as the
                interface expects that type */
-            m_dbusIface->call("SetActiveSection", (uint)m_activeSection);
+            m_dbusIface->asyncCall("SetActiveSection", (uint)m_activeSection);
         }
         Q_EMIT activeSectionChanged();
     }
@@ -582,14 +582,14 @@
     if (active != m_active) {
         m_active = active;
         if (m_dbusIface != NULL) {
-            m_dbusIface->call("SetActive", m_active);
+            m_dbusIface->asyncCall("SetActive", m_active);
         }
         Q_EMIT activeChanged();
 
         if (m_dbusIface && m_active) {
             /* SetActiveSection needs to be called after SetActive(true)
                in order for it to have an effect. */
-            m_dbusIface->call("SetActiveSection", m_activeSection);
+            m_dbusIface->asyncCall("SetActiveSection", m_activeSection);
         }
     }
 }
@@ -601,7 +601,7 @@
         m_entrySearchQuery = entrySearchQuery;
         if (m_dbusIface != NULL) {
             QHash<QString, QString> searchHints;
-            m_dbusIface->call("SetSearch", m_entrySearchQuery, qVariantFromValue(searchHints));
+            m_dbusIface->asyncCall("SetSearch", m_entrySearchQuery, qVariantFromValue(searchHints));
         }
         Q_EMIT entrySearchQueryChanged();
     }
@@ -680,7 +680,7 @@
         m_globalSearchQuery = globalSearchQuery;
         if (m_dbusIface != NULL) {
             QHash<QString, QString> searchHints;
-            m_dbusIface->call("SetGlobalSearch", m_globalSearchQuery, qVariantFromValue(searchHints));
+            m_dbusIface->asyncCall("SetGlobalSearch", m_globalSearchQuery, qVariantFromValue(searchHints));
         }
         Q_EMIT globalSearchQueryChanged();
     }
@@ -917,10 +917,10 @@
 
     /* Update state of D-Bus daemon according to the values of local properties */
     QHash<QString, QString> searchHints;
-    m_dbusIface->call("SetSearch", m_entrySearchQuery, qVariantFromValue(searchHints));
-    m_dbusIface->call("SetGlobalSearch", m_globalSearchQuery, qVariantFromValue(searchHints));
-    m_dbusIface->call("SetActive", m_active);
-    m_dbusIface->call("SetActiveSection", m_activeSection);
+    m_dbusIface->asyncCall("SetSearch", m_entrySearchQuery, qVariantFromValue(searchHints));
+    m_dbusIface->asyncCall("SetGlobalSearch", m_globalSearchQuery, qVariantFromValue(searchHints));
+    m_dbusIface->asyncCall("SetActive", m_active);
+    m_dbusIface->asyncCall("SetActiveSection", m_activeSection);
 }
 
 void