Code review comment for lp:~fboucault/unity-2d/opengl_switch

Revision history for this message
Olivier Tilloy (osomon) wrote :

@Florian: the code looks good to me, I still need to test it.

One comment/question on your way of retrieving the command line arguments for the application:

+ QSet<QString> arguments = QSet<QString>::fromList(QCoreApplication::arguments());

Why do you need a QSet? Can’t you just use the QStringList returned by QCoreApplication::arguments() ?
QLists also have a 'contains' method, so it should be fine.

« Back to merge proposal