unity-2d

Merge lp:~fboucault/unity-2d/launcher_more_items_cue into lp:unity-2d/3.0

  1. launcher_more_items_cue
  2. Merge into natty
Proposed by Florian Boucault
Status: Merged
Approved by: Florian Boucault
Approved revision: 501
Merged at revision: 509
Proposed branch: lp:~fboucault/unity-2d/launcher_more_items_cue
Merge into: lp:unity-2d/3.0
Diff against target: 0 lines
To merge this branch: bzr merge lp:~fboucault/unity-2d/launcher_more_items_cue
Reviewer Review Type Date Requested Status
Olivier Tilloy (community) Approve
Review via email: mp+55728@code.launchpad.net

Description of the change

[launcher] Fade out items at bottom/top if more items are available but invisible.

Forward port from maverick branch revision 425 plus improvements to cope with the shelf properly.

To post a comment you must log in.
lp:~fboucault/unity-2d/launcher_more_items_cue updated
498. By Florian Boucault

Fixed autoscrolling.

Revision history for this message
Olivier Tilloy (osomon) wrote :

Left-clicking on the trash in the shelf doesn’t open it. Right-clicking works though.

review: Needs Fixing (functional)
lp:~fboucault/unity-2d/launcher_more_items_cue updated
499. By Florian Boucault

Merged from trunk.

500. By Florian Boucault

Fixed stacking of all launcher components.

Revision history for this message
Olivier Tilloy (osomon) wrote :

It works like a charm now.

One tiny style nitpick before we can mark this approved:

+ height: Math.max(0, Math.min(list.contentHeight*(1-list.visibleArea.heightRatio)-list.contentY, 50))

Could you please add whitespaces around binary operators? This will improve readability, thanks!

review: Approve
lp:~fboucault/unity-2d/launcher_more_items_cue updated
501. By Florian Boucault

Fixed style nitpick.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches