Merge lp:~fboucault/unity-2d/launcher_device_icons into lp:unity-2d/3.0
Proposed by
Florian Boucault
Status: | Merged |
---|---|
Approved by: | Aurélien Gâteau |
Approved revision: | 551 |
Merged at revision: | 558 |
Proposed branch: | lp:~fboucault/unity-2d/launcher_device_icons |
Merge into: | lp:unity-2d/3.0 |
Diff against target: |
28 lines (+10/-1) 1 file modified
launcher/UnityApplications/launcherdevice.cpp (+10/-1) |
To merge this branch: | bzr merge lp:~fboucault/unity-2d/launcher_device_icons |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aurélien Gâteau (community) | Approve | ||
Review via email: mp+59377@code.launchpad.net |
Description of the change
[launcher] Use appropriate icon for devices depending on their type (instead of always showing a USB icon).
To post a comment you must log in.
Looks good, but code could be simplified by taking advantage of the GScopedPointer classes. Also you can return QString(), it is a tiny bit more efficient than QString("").