Merge lp:~fboucault/unity-2d/improve_launcher_smoothness into lp:unity-2d/3.0

Proposed by Florian Boucault
Status: Merged
Approved by: Ugo Riboni
Approved revision: 561
Merged at revision: 564
Proposed branch: lp:~fboucault/unity-2d/improve_launcher_smoothness
Merge into: lp:unity-2d/3.0
Diff against target: 13 lines (+3/-0)
1 file modified
launcher/Launcher.qml (+3/-0)
To merge this branch: bzr merge lp:~fboucault/unity-2d/improve_launcher_smoothness
Reviewer Review Type Date Requested Status
Ugo Riboni (community) Needs Information
Review via email: mp+60605@code.launchpad.net

Description of the change

[launcher] Ensure all delegates are cached in order to improve smoothness of scrolling on very low end platforms.

To post a comment you must log in.
Revision history for this message
Ugo Riboni (uriboni) wrote :

On my non-low-end hardware there is no loss or increase in smoothness.
The patch looks ok to me though, if you think the memory increase you get by caching the delegates is worth it (they will never be that many anyway)

review: Needs Information

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'launcher/Launcher.qml'
2--- launcher/Launcher.qml 2011-04-18 15:57:01 +0000
3+++ launcher/Launcher.qml 2011-05-11 10:34:45 +0000
4@@ -63,6 +63,9 @@
5 height: (tileSize + itemPadding) * count
6 width: parent.width
7 itemPadding: 0
8+ /* Ensure all delegates are cached in order to improve smoothness of
9+ scrolling on very low end platforms */
10+ cacheBuffer: 10000
11
12 model: ListAggregatorModel {
13 id: shelfItems

Subscribers

People subscribed via source and target branches