Merge lp:~fboucault/unity-2d/fix_indicators_pushed_off_screen into lp:unity-2d/3.0

Proposed by Florian Boucault
Status: Merged
Approved by: Aurélien Gâteau
Approved revision: 449
Merged at revision: 448
Proposed branch: lp:~fboucault/unity-2d/fix_indicators_pushed_off_screen
Merge into: lp:unity-2d/3.0
Diff against target: 28 lines (+3/-2)
1 file modified
panel/applets/appname/appnameapplet.cpp (+3/-2)
To merge this branch: bzr merge lp:~fboucault/unity-2d/fix_indicators_pushed_off_screen
Reviewer Review Type Date Requested Status
Aurélien Gâteau (community) Approve
Review via email: mp+53158@code.launchpad.net

Description of the change

[panel] Make sure long menus do not push indicators off screen.

To post a comment you must log in.
Revision history for this message
Florian Boucault (fboucault) wrote :

This MR needs to be reviewed after https://code.launchpad.net/~fboucault/unity-2d/window_buttons_left_aligned_and_fixed_width/+merge/53155.

The branch in this MR was branched from the one in the other merge request.

Revision history for this message
Florian Boucault (fboucault) wrote :
Revision history for this message
Aurélien Gâteau (agateau) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'panel/applets/appname/appnameapplet.cpp'
2--- panel/applets/appname/appnameapplet.cpp 2011-01-15 01:41:03 +0000
3+++ panel/applets/appname/appnameapplet.cpp 2011-03-13 03:55:53 +0000
4@@ -144,6 +144,7 @@
5 void setupWindowButtonWidget()
6 {
7 m_windowButtonWidget = new QWidget;
8+ m_windowButtonWidget->setSizePolicy(QSizePolicy::Fixed, QSizePolicy::Minimum);
9 QHBoxLayout* layout = new QHBoxLayout(m_windowButtonWidget);
10 layout->setContentsMargins(0, 0, WINDOW_BUTTONS_RIGHT_MARGIN, 0);
11 layout->setSpacing(0);
12@@ -187,7 +188,7 @@
13 : d(new AppNameAppletPrivate)
14 {
15 d->q = this;
16- setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Minimum);
17+ setSizePolicy(QSizePolicy::Ignored, QSizePolicy::Minimum);
18
19 d->setupWindowHelper();
20 d->setupLabel();
21@@ -198,7 +199,7 @@
22 QHBoxLayout* layout = new QHBoxLayout(this);
23 layout->setMargin(0);
24 layout->setSpacing(0);
25- layout->addWidget(d->m_windowButtonWidget);
26+ layout->addWidget(d->m_windowButtonWidget, 0, Qt::AlignLeft);
27 layout->addWidget(d->m_label);
28 layout->addWidget(d->m_menuBarWidget);
29

Subscribers

People subscribed via source and target branches