Code review comment for lp:~fboucault/unity-2d/fix_geis_gesture_names

Revision history for this message
Olivier Tilloy (osomon) wrote :

My testing abilities are limited because I’m not running Natty natively on my macbook yet, therefore the trackpad doesn’t work in a virtual machine. So I’ll take your word for it that it fixes touch support on Natty.

However I did as many sanity checks as possible on your changes, and they look sane and complete. The code compiles both on Maverick and Natty, but it (silently) breaks touch support on Maverick: this change should *not* be backported to Maverick, unless the corresponding version of libutouch-geis is backported too.

review: Approve

« Back to merge proposal