unity-2d

Merge lp:~fboucault/unity-2d/dash_renderer_fallback into lp:unity-2d

  1. dash_renderer_fallback
  2. Merge into trunk
Proposed by Florian Boucault
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 678
Merged at revision: 683
Proposed branch: lp:~fboucault/unity-2d/dash_renderer_fallback
Merge into: lp:unity-2d
Diff against target: 16 lines (+4/-2)
1 file modified
places/LensView.qml (+4/-2)
To merge this branch: bzr merge lp:~fboucault/unity-2d/dash_renderer_fallback
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
Review via email: mp+73445@code.launchpad.net

Description of the change

[dash] Fallback to using the default renderer if renderer requested by the lens is not found.

To post a comment you must log in.
Revision history for this message
Alberto Mardegan (mardy) wrote :

Works great, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'places/LensView.qml'
2--- places/LensView.qml 2011-08-24 12:44:05 +0000
3+++ places/LensView.qml 2011-08-30 21:25:24 +0000
4@@ -85,8 +85,10 @@
5
6 source: rendererName ? Utils.convertToCamelCase(rendererName) + ".qml" : ""
7 onStatusChanged: {
8- if (status == Loader.Error)
9- console.log("Failed to load renderer", rendererName)
10+ if (status == Loader.Error) {
11+ console.log("Failed to load renderer %1. Using default renderer instead.".arg(rendererName))
12+ source = "TileVertical.qml"
13+ }
14 }
15
16 /* Model that will be used by the category's delegate */

Subscribers

People subscribed via source and target branches