Merge lp:~fboucault/ubuntu-ui-toolkit/themed_list_items_progression into lp:ubuntu-ui-toolkit

[Florian Boucault]

List item progression: use appropriate icon (same as Tabs' arrow) and fixes the issue of it being the wrong color in Dark and Gradient themes.

[Zsombor Egri (zsombi)]

A nice one! Finally styled!!! Thank you!

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:885
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/1424/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1529
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1485
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-amd64-ci/372
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-armhf-ci/372
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-armhf-ci/372/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1360
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1529
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1529/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1485
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1485/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/4014
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/2174

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-toolkit-ci/1424/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-autolanding/504/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1531
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1487/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-amd64-autolanding/107
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-armhf-autolanding/107
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-armhf-autolanding/107/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1361
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1531
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1531/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1487
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1487/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/4016/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/2176

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'modules/Ubuntu/Components/ListItems/ProgressionVisual.qml'
--- modules/Ubuntu/Components/ListItems/ProgressionVisual.qml	2013-04-26 19:23:36 +0000
+++ modules/Ubuntu/Components/ListItems/ProgressionVisual.qml	2013-12-09 12:25:49 +0000
@@ -15,38 +15,15 @@
  */
 
 import QtQuick 2.0
+import Ubuntu.Components 0.1
 
 // Internal helper class for the visuals of
 // the progression symbol.
-Item {
+StyledItem {
     id: progressionVisual
 
-    width: progressIcon.width + (showSplit ? splitMargin + progressionDivider.width : 0)
-
     property bool showSplit: false
     property real splitMargin
 
-    Image {
-        id: progressIcon
-        source: "artwork/ListItemProgressionArrow.png"
-        anchors {
-            verticalCenter: parent.verticalCenter
-            right: parent.right
-        }
-
-        opacity: enabled ? 1.0 : 0.5
-    }
-
-    Image {
-        id: progressionDivider
-        visible: progressionVisual.showSplit
-        anchors {
-            top: parent.top
-            bottom: parent.bottom
-            right: progressIcon.left
-            rightMargin: splitMargin
-        }
-        source: "artwork/ListItemDividerVertical.png"
-        opacity: enabled ? 1.0 : 0.5
-    }
+    style: Theme.createStyleComponent("ProgressionVisualStyle.qml", progressionVisual)
 }

=== removed file 'modules/Ubuntu/Components/ListItems/artwork/[e-mail]'
Binary files modules/Ubuntu/Components/ListItems/artwork/[e-mail]	2012-11-21 12:07:16 +0000 and modules/Ubuntu/Components/ListItems/artwork/[e-mail]	1970-01-01 00:00:00 +0000 differ
=== added file 'modules/Ubuntu/Components/Themes/Ambiance/ProgressionVisualStyle.qml'
--- modules/Ubuntu/Components/Themes/Ambiance/ProgressionVisualStyle.qml	1970-01-01 00:00:00 +0000
+++ modules/Ubuntu/Components/Themes/Ambiance/ProgressionVisualStyle.qml	2013-12-09 12:25:49 +0000
@@ -0,0 +1,51 @@
+/*
+ * Copyright 2013 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import QtQuick 2.0
+import Ubuntu.Components 0.1
+
+Item {
+    id: progressionVisualStyle
+
+    property url progressionDividerSource: "artwork/progression_divider.png"
+    property url progressionIconSource: "artwork/chevron.png"
+
+    implicitWidth: progressIcon.width + (styledItem.showSplit ? styledItem.splitMargin + progressionDivider.width : 0)
+
+    Image {
+        id: progressIcon
+        source: progressionIconSource
+        anchors {
+            verticalCenter: parent.verticalCenter
+            right: parent.right
+        }
+
+        opacity: enabled ? 1.0 : 0.5
+    }
+
+    Image {
+        id: progressionDivider
+        visible: styledItem.showSplit
+        anchors {
+            top: parent.top
+            bottom: parent.bottom
+            right: progressIcon.left
+            rightMargin: styledItem.splitMargin
+        }
+        source: progressionDividerSource
+        opacity: enabled ? 1.0 : 0.5
+    }
+}

=== renamed file 'modules/Ubuntu/Components/ListItems/artwork/[e-mail]' => 'modules/Ubuntu/Components/Themes/Ambiance/artwork/[e-mail]'