Code review comment for lp:~fboucault/ubuntu-ui-toolkit/simple_theming

Revision history for this message
Florian Boucault (fboucault) wrote :

> Two small things to be fixed still:
> - UCTheme::setName(), ::createStyleComponent(), ::styleUrl() and
> ::parentThemeName() can take const QString& as parameter.

We only have a short window to merge this and the 4 other apps so that the build does not break. Can we avoid this detail? (also note that QStrings are shared implicity therefore no copy is occuring when passing by value)

> - because of common.pri removal we have two warnings in Layouts.pro and
> Layouts\plugin.pro. I think we should fix those, either here or in a separate
> MR.

Why here? the removal of common.pri was done in trunk.

« Back to merge proposal