Merge lp:~fboucault/ubuntu-ui-toolkit/sections_icon_asynchronous into lp:ubuntu-ui-toolkit/staging

Proposed by Florian Boucault
Status: Merged
Approved by: Tim Peeters
Approved revision: 2041
Merged at revision: 2053
Proposed branch: lp:~fboucault/ubuntu-ui-toolkit/sections_icon_asynchronous
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 19 lines (+2/-0)
1 file modified
src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml (+2/-0)
To merge this branch: bzr merge lp:~fboucault/ubuntu-ui-toolkit/sections_icon_asynchronous
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Tim Peeters Approve
Andrea Bernabei (community) Approve
Review via email: mp+301059@code.launchpad.net

Commit message

Sections: load Icons asynchronously.

Description of the change

Sections: load Icons asynchronously.

To post a comment you must log in.
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrea Bernabei (faenil) wrote :

LGTM, thanks!

review: Approve
Revision history for this message
Tim Peeters (tpeeters) wrote :

Thanks, happroving.

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml'
2--- src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml 2016-06-13 15:57:20 +0000
3+++ src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml 2016-07-25 12:41:11 +0000
4@@ -287,6 +287,7 @@
5 width: units.gu(1)
6 height: units.gu(1)
7 visible: false
8+ asynchronous: true
9 rotation: 180
10 opacity: visible
11 ? sectionsListView.atXBeginning ? hoveringArea.iconsDisabledOpacity : 1.0
12@@ -316,6 +317,7 @@
13 width: units.gu(1)
14 height: units.gu(1)
15 visible: false
16+ asynchronous: true
17 opacity: visible
18 ? sectionsListView.atXEnd ? hoveringArea.iconsDisabledOpacity : 1.0
19 : 0.0

Subscribers

People subscribed via source and target branches