Merge lp:~fboucault/ubuntu-ui-toolkit/revert_658_fixes_crash into lp:ubuntu-ui-toolkit

Proposed by Florian Boucault
Status: Merged
Approved by: MichaƂ Sawicz
Approved revision: 660
Merged at revision: 661
Proposed branch: lp:~fboucault/ubuntu-ui-toolkit/revert_658_fixes_crash
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 79 lines (+0/-36)
3 files modified
modules/Ubuntu/Components/OrientationHelper.qml (+0/-8)
modules/Ubuntu/Components/plugin/plugin.cpp (+0/-22)
modules/Ubuntu/Components/plugin/plugin.h (+0/-6)
To merge this branch: bzr merge lp:~fboucault/ubuntu-ui-toolkit/revert_658_fixes_crash
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Tim Peeters Pending
Review via email: mp+177254@code.launchpad.net

Commit message

Reverted revision 658 introducing reporting of content orientation. Was causing crashes on x86.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/OrientationHelper.qml'
2--- modules/Ubuntu/Components/OrientationHelper.qml 2013-07-24 18:16:10 +0000
3+++ modules/Ubuntu/Components/OrientationHelper.qml 2013-07-27 12:15:31 +0000
4@@ -91,14 +91,6 @@
5
6 Component.onCompleted: orientationTransition.enabled = transitionEnabled
7
8- /*!
9- \internal
10-
11- Report the current orientation of the application via QWindow::contentOrientation.
12- http://qt-project.org/doc/qt-5.0/qtgui/qwindow.html#contentOrientation-prop
13- */
14- onOrientationAngleChanged: window.contentOrientation = Screen.orientation
15-
16 Item {
17 id: stateWrapper
18
19
20=== modified file 'modules/Ubuntu/Components/plugin/plugin.cpp'
21--- modules/Ubuntu/Components/plugin/plugin.cpp 2013-07-26 11:33:12 +0000
22+++ modules/Ubuntu/Components/plugin/plugin.cpp 2013-07-27 12:15:31 +0000
23@@ -100,26 +100,6 @@
24 }
25 }
26
27-void UbuntuComponentsPlugin::registerWindowContextProperty()
28-{
29- setWindowContextProperty(QGuiApplication::focusWindow());
30-
31- // listen to QGuiApplication::focusWindowChanged
32- QGuiApplication* application = static_cast<QGuiApplication*>(QCoreApplication::instance());
33- QObject::connect(application, SIGNAL(focusWindowChanged(QWindow*)),
34- this, SLOT(setWindowContextProperty(QWindow*)));
35-
36-}
37-
38-void UbuntuComponentsPlugin::setWindowContextProperty(QWindow* focusWindow)
39-{
40- QQuickView* view = qobject_cast<QQuickView*>(focusWindow);
41-
42- if (view != NULL) {
43- view->rootContext()->setContextProperty("window", view);
44- }
45-}
46-
47 void UbuntuComponentsPlugin::registerTypes(const char *uri)
48 {
49 Q_ASSERT(uri == QLatin1String("Ubuntu.Components"));
50@@ -184,6 +164,4 @@
51 Qt::LandscapeOrientation |
52 Qt::InvertedPortraitOrientation |
53 Qt::InvertedLandscapeOrientation);
54-
55- registerWindowContextProperty();
56 }
57
58=== modified file 'modules/Ubuntu/Components/plugin/plugin.h'
59--- modules/Ubuntu/Components/plugin/plugin.h 2013-07-26 11:32:55 +0000
60+++ modules/Ubuntu/Components/plugin/plugin.h 2013-07-27 12:15:31 +0000
61@@ -22,8 +22,6 @@
62 #include <QtQml/QQmlEngine>
63 #include <QtQml/QQmlExtensionPlugin>
64
65-class QWindow;
66-
67 class UbuntuComponentsPlugin : public QQmlExtensionPlugin
68 {
69 Q_OBJECT
70@@ -34,10 +32,6 @@
71 void initializeEngine(QQmlEngine *engine, const char *uri);
72 QUrl baseUrl(QStringList importPathList, const char* uri);
73 void registerQmlSingletonType(QQmlEngine *engine, const char* uri, const char* typeName, const char* qmlFile);
74-
75-private Q_SLOTS:
76- void registerWindowContextProperty();
77- void setWindowContextProperty(QWindow* focusWindow);
78 };
79 #endif // UBUNTU_COMPONENTS_PLUGIN_H
80

Subscribers

People subscribed via source and target branches

to status/vote changes: