Merge lp:~fboucault/ubuntu-ui-toolkit/mainview_no_background_overdraw into lp:ubuntu-ui-toolkit/staging

Proposed by Florian Boucault
Status: Merged
Approved by: Tim Peeters
Approved revision: 1815
Merged at revision: 1816
Proposed branch: lp:~fboucault/ubuntu-ui-toolkit/mainview_no_background_overdraw
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 35 lines (+14/-0)
2 files modified
src/Ubuntu/Components/Themes/Ambiance/1.2/MainViewStyle.qml (+7/-0)
src/Ubuntu/Components/Themes/Ambiance/1.3/MainViewStyle.qml (+7/-0)
To merge this branch: bzr merge lp:~fboucault/ubuntu-ui-toolkit/mainview_no_background_overdraw
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+283397@code.launchpad.net

Commit message

MainView: when no gradient color is needed for the background, rely on QQuickWindow's GL clear color. Lessens overdraw considerably for most apps.

To post a comment you must log in.
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

Nais!!!

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-autolanding/87/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-land-mp/87/console

review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

The CI was affected by IS actions, this needs re-topapproving.

Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/Themes/Ambiance/1.2/MainViewStyle.qml'
2--- src/Ubuntu/Components/Themes/Ambiance/1.2/MainViewStyle.qml 2015-04-24 14:52:19 +0000
3+++ src/Ubuntu/Components/Themes/Ambiance/1.2/MainViewStyle.qml 2016-01-21 12:47:26 +0000
4@@ -40,6 +40,13 @@
5 anchors.fill: parent
6 color: styledItem.backgroundColor
7 gradient: internals.isGradient ? backgroundGradient : null
8+ visible: internals.isGradient
9+ }
10+
11+ Binding {
12+ target: typeof window != 'undefined' ? window : null
13+ property: "color"
14+ value: styledItem.backgroundColor
15 }
16
17 Image {
18
19=== modified file 'src/Ubuntu/Components/Themes/Ambiance/1.3/MainViewStyle.qml'
20--- src/Ubuntu/Components/Themes/Ambiance/1.3/MainViewStyle.qml 2015-08-06 22:50:04 +0000
21+++ src/Ubuntu/Components/Themes/Ambiance/1.3/MainViewStyle.qml 2016-01-21 12:47:26 +0000
22@@ -57,6 +57,13 @@
23 anchors.fill: parent
24 color: mainViewStyle.backgroundColor
25 gradient: internals.isGradient ? backgroundGradient : null
26+ visible: internals.isGradient
27+ }
28+
29+ Binding {
30+ target: typeof window != 'undefined' ? window : null
31+ property: "color"
32+ value: mainViewStyle.backgroundColor
33 }
34
35 QtObject {

Subscribers

People subscribed via source and target branches