Merge lp:~fboucault/ubuntu-ui-toolkit/activity_indicator_animator_rtm into lp:ubuntu-ui-toolkit/rtm

Proposed by Florian Boucault on 2015-01-15
Status: Merged
Approved by: Zoltan Balogh on 2015-01-20
Approved revision: 1138
Merged at revision: 1138
Proposed branch: lp:~fboucault/ubuntu-ui-toolkit/activity_indicator_animator_rtm
Merge into: lp:ubuntu-ui-toolkit/rtm
Diff against target: 17 lines (+1/-6)
1 file modified
modules/Ubuntu/Components/Themes/Ambiance/ActivityIndicatorStyle.qml (+1/-6)
To merge this branch: bzr merge lp:~fboucault/ubuntu-ui-toolkit/activity_indicator_animator_rtm
Reviewer Review Type Date Requested Status
Zoltan Balogh (community) 2015-01-15 Approve on 2015-01-20
Review via email: mp+246631@code.launchpad.net

Commit Message

ActivityIndicator: make its animation rely solely on the rendering thread so that it does not stop spinning if the main thread is blocked.

Description of the Change

ActivityIndicator: make its animation rely solely on the rendering thread so that it does not stop spinning if the main thread is blocked.

To post a comment you must log in.
Zoltan Balogh (bzoltan) wrote :

ok

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/Themes/Ambiance/ActivityIndicatorStyle.qml'
2--- modules/Ubuntu/Components/Themes/Ambiance/ActivityIndicatorStyle.qml 2014-07-08 10:59:01 +0000
3+++ modules/Ubuntu/Components/Themes/Ambiance/ActivityIndicatorStyle.qml 2015-01-15 19:39:48 +0000
4@@ -28,12 +28,7 @@
5 verticalAlignment: Image.AlignVCenter
6 source: "artwork/spinner.png"
7
8- /*
9- Changed from RotationAnimator to RotationAnimation to
10- work around bug: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1338602
11- "Activity Indicator crashes in QML/Widget mixed applications"
12- */
13- RotationAnimation on rotation {
14+ RotationAnimator on rotation {
15 running: styledItem.running
16 from: 0
17 to: 360

Subscribers

People subscribed via source and target branches