Merge lp:~fboucault/ubuntu-ui-extras/current_tab_visible_startup into lp:ubuntu-ui-extras/staging

Proposed by Florian Boucault on 2017-04-05
Status: Needs review
Proposed branch: lp:~fboucault/ubuntu-ui-extras/current_tab_visible_startup
Merge into: lp:ubuntu-ui-extras/staging
Diff against target: 12 lines (+2/-0)
1 file modified
modules/Ubuntu/Components/Extras/TabsBar.qml (+2/-0)
To merge this branch: bzr merge lp:~fboucault/ubuntu-ui-extras/current_tab_visible_startup
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing on 2017-04-05
Andrew Hayzen (community) 2017-04-05 Approve on 2017-04-05
Review via email: mp+321991@code.launchpad.net

This proposal supersedes a proposal from 2017-04-05.

Commit message

TabsBar: ensure selected tab is always visible when width changes, including at startup.

Description of the change

TabsBar: ensure selected tab is always visible when width changes, including at startup.

To post a comment you must log in.
Andrew Hayzen (ahayzen) wrote :

LGTM, resolves the issue :-)

review: Approve

PASSED: Continuous integration, rev:136
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-ui-extras-staging-ci/12/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2428
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2428
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2239
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2239/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2239
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2239/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2239
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2239/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2239
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2239/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2239
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2239/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2239
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2239/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-ui-extras-staging-ci/12/rebuild

review: Approve (continuous-integration)

FAILED: Autolanding.
More details in the following jenkins job:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-ui-extras-staging-autoland/70/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/2470/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2470
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2281
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2281/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2281
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2281/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2281
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2281/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2281/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2281
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2281/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2281
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2281/artifact/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)

Unmerged revisions

136. By Florian Boucault on 2017-04-05

TabsBar: ensure selected tab is always visible when width changes, including at startup.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/Extras/TabsBar.qml'
2--- modules/Ubuntu/Components/Extras/TabsBar.qml 2017-01-16 15:31:24 +0000
3+++ modules/Ubuntu/Components/Extras/TabsBar.qml 2017-04-05 13:32:40 +0000
4@@ -186,6 +186,8 @@
5 UbuntuNumberAnimation { property: "x" }
6 }
7
8+ // Ensures current item stays visible when width changes
9+ onWidthChanged: tabs.positionViewAtIndex(currentIndex, ListView.Contain)
10 currentIndex: tabsBar.model.selectedIndex
11 model: tabsBar.model
12 delegate: MouseArea {

Subscribers

People subscribed via source and target branches